-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert README
and CONTRIBUTING
from Markdown to AsciiDoc
#7527
Conversation
I'm a bit disappointed GitHub didn't keep the "moved" state for the two files like in my first commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! The Jenkins project loves AsciiDoc, so this not only improves consistency within this repository but also consistency with the broader Jenkins ecosystem, such as jenkins-infra/jenkins.io
(which heavily relies on AsciiDoc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. One optional comment that the link to friendly issues would probably be better if it opened the friendly issues table rather than the list of friendly issues. That is optional. Thanks!
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
README
and CONTRIBUTING
from Markdown to AsciiDoc
Merging as-is has broken all of our, and third party, links to contributing.md, see |
Note that it will also break all external links to CONTRIBUTING, and we
heavily use them e.g. in GSoC materials
…On Sat, Dec 17, 2022 at 9:58 PM Alexander Brandes ***@***.***> wrote:
Merging as-is has broken all of our, and third party, links to
contributing.md, see Building and Debugging Jenkins on jenkins.io
<https://www.jenkins.io/doc/developer/building/#references> for just one
example.
—
Reply to this email directly, view it on GitHub
<#7527 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIBXEW2NZFUD5ZWMO5LWNYSO7ANCNFSM6AAAAAATAII43I>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
…jenkinsci#7527)" This reverts commit 48edf2c.
Created #7533 to revert this for now. |
I should have though about that, sorry and thanks Alex for taking care of the revert. I'll rework it next week, maybe something like a redirection for example. |
Sounds good, I'm open to alternative approaches, that don't break existing URLs for sure. To be fair, I was under the impression GH warrants redirections, maybe that applies to GH pages only 🤷🏻 |
Follow-up of my first (misplaced) suggestions on the "Disambiguate and document the closure process" pull request: #7516 (comment)
This PR converts the existing two Markdown documents present in the root folder to Asciidoc, in order to be able to move the
/docs/MAINTAINERS.adoc
file in the root folder too as it's alone in this/docs/
folder. (Subsequent PR: #7528)Testing done
Visual inspection and comparison of the rendered AsciiDoc (README.adoc and CONTRIBUTING.adoc) with the original Markdown to confirm there were no rendering errors.
Notes / compromises concerning both documents:
GitHub renders Asciidoc with a bigger line spacing than Markdown.
Concerning CONTRIBUTING:
The "exclamation" Asciidoc render at the beginning differs from the Markdown one, I didn't find a way to include this emoticon without the block. Open to alternatives.
The IntelliJ listed options are now correctly displayed in Asciidoc.
As there can be only one "level 0" section, I had to change the level of the "Links" section title at the end.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@basil
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).