Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify label to 'Jenkins user database' #9024

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Mar 8, 2024

Thoughts about this simplification in the label?

Pros:

Cons:

  • It could more easily be confused with security realm as a term ("My Jenkins user database is LDAP").

Testing done

config screenshot breadcrumb screenshot

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite
Copy link
Contributor

I am "+1" for the change. I think the benefits are worth the change.

@StefanSpieker
Copy link
Contributor

I am +1 for adjusting, we could also rename it to internal user database - I think the word Jenkins is of no use there.

@@ -25,7 +25,7 @@ GlobalSecurityConfiguration.Description=Secure Jenkins; define who is allowed to
HudsonPrivateSecurityRealm.WouldYouLikeToSignUp=This {0} {1} is new to Jenkins. Would you like to sign up?
LegacyAuthorizationStrategy.DisplayName=Legacy mode

HudsonPrivateSecurityRealm.DisplayName=Jenkins’ own user database
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Stefan in #9024 (comment).
Jenkins is unneeded, I'm not a huge fan of user database though, but I could live with it.

What about one of these?

Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Local authentication
Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Internal
Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants