Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73243] quote replacement string in symbol tooltips #9347

Merged
merged 3 commits into from
Jun 6, 2024
Merged

[JENKINS-73243] quote replacement string in symbol tooltips #9347

merged 3 commits into from
Jun 6, 2024

Commits on Jun 3, 2024

  1. [JENKINS-73243] quote replacement string in symbol tooltips 

    when the tooltip or html tooltip for a symbol contained the $ sign,
then adding the tooltip failed with `Illegal group reference`.

e.g.

```
<l:icon src="symbol-add" tooltip="$test"/>
```

Added unit test that ensures tooltips are properly quoted
    @mawinter69
    mawinter69 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ec33815 View commit details
    Browse the repository at this point in the history

  2. also quote id element

    @mawinter69
    mawinter69 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8c5426a View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. add Issue

    @mawinter69
    mawinter69 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    22e8032 View commit details
    Browse the repository at this point in the history