-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dependents toggle in plugin manager with system read #9463
Disable dependents toggle in plugin manager with system read #9463
Conversation
Tests are failing |
checkbox.addEventListener("click", () => { | ||
setTimeout(() => { | ||
updateButton.disabled = !anyCheckboxesSelected(); | ||
if (updateButton) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor fix I noticed while checking this again, tests were logging a giant stacktrace, this button is only on the updates page and not the installed page so its event listener shouldn't be active
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
It was reported as jenkinsci/dark-theme-plugin#258 although nothing to do with dark theme.
One of the tds has some metadata added with display:none which was being excluded by the
isAdmin
check.This narrows the
isAdmin
down so dependents and dependencies correctly show up in the metadataTesting done
Tested with system read:
Tested with admin:
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist