Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73838] Compatibility for Jenkins#doSafeRestart(StaplerRequest, String) #9797

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

basil
Copy link
Member

@basil basil commented Sep 30, 2024

See JENKINS-73838. Minor flaw in the EE 9 compatibility layer: Jenkins#doSafeRestart(StaplerRequest, String) was changed to StaplerRequest2 without providing a compatibility method, resulting in a proprietary plugin failing with:

java.lang.NoSuchMethodError: 'org.kohsuke.stapler.HttpResponse jenkins.model.Jenkins.doSafeRestart(org.kohsuke.stapler.StaplerRequest, java.lang.String)'

Fixed by providing the missing method.

Testing done

Verified that the call to Jenkins#doSafeRestart(StaplerRequest, String) could not be compiled with 2.478 but could be compiled after this PR.

Proposed changelog entries

Restore compatibility with plugins calling Jenkins#doSafeRestart(StaplerRequest, String).

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Sep 30, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 2, 2024
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@basil basil merged commit 77c3d7a into jenkinsci:master Oct 4, 2024
15 checks passed
@basil basil deleted the JENKINS-73838 branch October 4, 2024 16:59
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants