Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify persistence design for temporarily offline status #9855

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Reduce visibility of Node#isTemporarilyOffline

1d20b1c
Select commit
Loading
Failed to load commit list.
Open

Simplify persistence design for temporarily offline status #9855

Reduce visibility of Node#isTemporarilyOffline
1d20b1c
Select commit
Loading
Failed to load commit list.
ci.jenkins.io / Code Coverage succeeded Oct 11, 2024 in 0s

Line Coverage: 86.21% (+12.42%), Branch Coverage: 95.00% (+33.51%)

Summary for modified lines

  • 69 lines have been modified
  • 4 lines are not covered
  • 4 lines are covered only partially

Overview by baseline

Quality Gates Summary

No active quality gates.

Details

Project coverage details

Module Coverage Package Coverage File Coverage Class Coverage Method Coverage Line Coverage Branch Coverage Instruction Coverage
🐾 Overall project 100.00% (3/3) 83.18% (89/107) 80.70% (987/1223) 79.44% (1982/2495) 65.47% (10670/16298) 66.04% (37020/56056) 59.67% (13490/22607) 65.77% (167007/253942)
📈 Overall project (difference to reference job) +0.00% +0.00% +0.00% +0.00% +0.01% ⬆️ -0.01% ⬇️ +0.01% ⬆️ +0.00%
🐾 Modified files 100.00% (2/2) 100.00% (3/3) 100.00% (4/4) 80.00% (16/20) 79.02% (162/205) 73.79% (563/763) 61.49% (214/348) 74.21% (2457/3311)
📈 Modified files (difference to reference job) n/a n/a n/a n/a n/a -0.07% ⬇️ +0.98% ⬆️ n/a
🐾 Modified code lines 100.00% (2/2) 66.67% (2/3) 75.00% (3/4) n/a n/a 86.21% (25/29) 95.00% (19/20) n/a
📈 Modified code lines (difference to modified files) n/a n/a n/a n/a n/a +12.42% ⬆️ +33.51% ⬆️ n/a
🐾 Indirect changes 100.00% (2/2) 50.00% (2/4) 57.14% (4/7) n/a n/a 28.57% (2/7) 42.86% (3/7) n/a

Annotations

Check warning on line 609 in core/src/main/java/hudson/model/Computer.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 609 is not covered by tests

Check warning on line 714 in core/src/main/java/hudson/model/Computer.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 714 is not covered by tests

Check warning on line 608 in core/src/main/java/hudson/model/Computer.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Partially covered line

Line 608 is only partially covered, one branch is missing

Check warning on line 250 in core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 236-250 are not covered by tests