Do not fail build in case of error while creating cache

jenkinsci · Feb 22, 2023 · 929649e · 929649e
1 parent 9501a66
commit 929649e
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/main/java/jenkins/plugins/jobcacher/ArbitraryFileCache.java b/src/main/java/jenkins/plugins/jobcacher/ArbitraryFileCache.java
@@ -368,12 +368,17 @@ public void save(ObjectPath cachesRoot, Run<?, ?> build, FilePath workspace, Lau
 
             logMessage("Creating cache...", listener);
             long cacheCreationStartTime = System.nanoTime();
-            compressionMethod.getCacheStrategy().cache(resolvedPath, includes, excludes, useDefaultExcludes, cache, workspace);
-            if (isCacheValidityDecidingFileConfigured() && isOneCacheValidityDecidingFilePresent(workspace)) {
-                updateSkipCacheTriggerFileHash(cachesRoot, workspace);
+
+            try {
+                compressionMethod.getCacheStrategy().cache(resolvedPath, includes, excludes, useDefaultExcludes, cache, workspace);
+                if (isCacheValidityDecidingFileConfigured() && isOneCacheValidityDecidingFilePresent(workspace)) {
+                    updateSkipCacheTriggerFileHash(cachesRoot, workspace);
+                }
+                long cacheCreationEndTime = System.nanoTime();
+                logMessage("Cache created in " + Duration.ofNanos(cacheCreationEndTime - cacheCreationStartTime).toMillis() + "ms", listener);
+            } catch (Exception e) {
+                logMessage("Failed to create cache", e, listener);
             }
-            long cacheCreationEndTime = System.nanoTime();
-            logMessage("Cache created in " + Duration.ofNanos(cacheCreationEndTime - cacheCreationStartTime).toMillis() + "ms", listener);
         }
 
         private boolean isPathOutsideWorkspace(FilePath workspace) {