-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use minimal SDK #228
Use minimal SDK #228
Conversation
Sorry for not yet replying. I will check it in the next days. |
@repolevedavaj Hi any update there ? |
@jonesbusy Yes i checked but wanted to contact you: What is the benefit of using the minimal plugin? |
@repolevedavaj The size. The minimal was created to optimize the size. It only contains core and basic service like S3. All the rest is not used by this plugin The difference is insane 3.68 MB for the minimal https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/plugins/aws-java-sdk/aws-java-sdk-minimal/1.12.586-413.v6a_6c3a_420126/ If you want to keep the all flavor (But I don't want to see a valid reason) can you perform the conditional check on the descriptor ? From https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ if (Jenkins.getInstance().getPlugin("aws-java-sdk") != null || Jenkins.getInstance().getPlugin("aws-java-sdk-minimal") != null ) {
} It don't bring any benefits in my opinion. Having user installing the minimal one even if they have already the Thanks! |
<artifactId>aws-java-sdk</artifactId> | ||
<version>${aws-java-sdk.version}</version> | ||
<groupId>org.jenkins-ci.plugins.aws-java-sdk</groupId> | ||
<artifactId>aws-java-sdk-minimal</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of bom
@jonesbusy OK I see your point and I agree that trying to maintain backwards compatibility in this case is probably not that useful. |
Currently migrating to external storage (artifact, etc..) and want to migrate job caches to S3 endpoint
Similar to S3 publisher : https://plugins.jenkins.io/s3/dependencies/, no need to bring all AWS dependencies (https://plugins.jenkins.io/aws-java-sdk-minimal/).
I'm not sure if there is a better migration path expect asking consumer to install the minimal SDK.
Testing done
Submitter checklist