Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @DataBoundSetter on wrong setter #273

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix @DataBoundSetter on wrong setter #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/jenkins/plugins/jobcacher/CacheWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ public void setSkipSave(boolean skipSave) {
this.skipSave = skipSave;
}

@DataBoundSetter
@SuppressWarnings("unused")
public void setSkipRestore(boolean skipRestore) {
this.skipRestore = skipRestore;
}

@DataBoundSetter
@SuppressWarnings("unused")
public boolean setSkipRestore() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be getSkipRestore ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... There was some mix-up with getter/setter.

I've reactivated the test and should fix the issue on #274

return skipRestore;
Expand Down
Loading