Avoid String concatenation in compareTo (#645)

jenkinsci · Sep 10, 2024 · 03d9d8a · 03d9d8a
1 parent 8d143ac
commit 03d9d8a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/main/java/hudson/tasks/junit/CaseResult.java b/src/main/java/hudson/tasks/junit/CaseResult.java
@@ -955,9 +955,13 @@ public int compareTo(CaseResult that) {
         if (this == that) {
             return 0;
         }
-        int r = this.getFullName().compareTo(that.getFullName());
-        if (r != 0) {
-            return r;
+        int r1 = this.className.compareTo(that.className);
+        if (r1 != 0) {
+            return r1;
+        }
+        int r2 = this.getName().compareTo(that.getName());
+        if (r2 != 0) {
+            return r2;
         }
         // Only equals is exact reference
         return System.identityHashCode(this) >= System.identityHashCode(that) ? 1 : -1;