Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67080] fix malformed json #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olamy
Copy link
Member

@olamy olamy commented Nov 8, 2021

Signed-off-by: Olivier Lamy [email protected]

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the issue?

If I load: https://ci.jenkins.io/job/Core/job/jenkins/job/master/2966/testReport/history/
I can't see any errors

(it is slow, but that would be fixed by moving to the sql storage plugin most likely).

If I load your PR on my local setup the history graphs don't load and I get this error:

Uncaught SyntaxError: Unexpected token o in JSON at position 1
    at JSON.parse (<anonymous>)
    at EChartsJenkinsApi.renderZoomableTrendChart (zoomable-trend-chart.js:10)
    at history.js:17
    at onSuccess (bind.js:57)
    at klass.respondToReadyState (prototype.js:1657)
    at klass.onStateChange (prototype.js:1600)
    at XMLHttpRequest.<anonymous> (prototype.js:414)
hudson-behavior.js:2911 Uncaught SyntaxError: Unexpected token o in JSON at position 1
    at JSON.parse (<anonymous>)
    at EChartsJenkinsApi.renderZoomableTrendChart (zoomable-trend-chart.js:10)
    at history.js:25
    at onSuccess (bind.js:57)
    at klass.respondToReadyState (prototype.js:1657)
    at klass.onStateChange (prototype.js:1600)
    at XMLHttpRequest.<anonymous> (prototype.js:414)

@olamy
Copy link
Member Author

olamy commented Nov 9, 2021

that's interesting because if using mvn hpi:run I can reproduce the issue. see screenshot https://issues.jenkins.io/browse/JENKINS-67080
yeah definitely history loading performance is a huge problem as the plugin should load results in parallel.

@timja
Copy link
Member

timja commented Nov 9, 2021

I was also using hpi:run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants