Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility change for kubernetes-client 6.x #73

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Compatibility change for kubernetes-client 6.x #73

merged 1 commit into from
Jan 10, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 10, 2023 •
edited
Loading

This makes this plugin compatible with kubernetes-client 6.x, which depends on having the context classloader set to the same as the calling class loader.

They also broke binary compatibility changing the generics interface, so some monkey patching is required until this plugin depends on it at compilation time.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe
Compatibility change for kubernetes-client 6.x
b639f55 
This makes this plugin compatible with kubernetes-client 6.x, which
depends on having the context classloader set to the same as the calling
class loader.

They also broke binary compatibility changing the generics interface, so
some monkey patching is required until this plugin depends on it at
compilation time.
@Vlatombe Vlatombe requested a review from a team as a code owner January 10, 2023 15:18
@Vlatombe Vlatombe mentioned this pull request Jan 10, 2023
Merged
6 tasks
jtnord
jtnord approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vlatombe

@jtnord jtnord added the enhancement New feature or request label Jan 10, 2023
@jtnord jtnord merged commit 128ee98 into jenkinsci:master Jan 10, 2023
@Vlatombe Vlatombe deleted the kubernetes-client-6.x-compat-fix branch January 10, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlatombe @jtnord