Skip kube-api-access Volume Comparison #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hotfixes the incompatibility between the Operator and Kubernetes 1.21. Kubernetes 1.21 started adding a new volume named "kube-api-access-<random-suffix>" and that broke the comparison function and resulted in an infinite loop.
KorusMateusz
approved these changes
Apr 28, 2021
tomaszsek
approved these changes
Apr 28, 2021
jsanchez034
pushed a commit
to animoto/kubernetes-operator
that referenced
this pull request
May 20, 2024
* Skip kube-api-access volume comparison This hotfixes the incompatibility between the Operator and Kubernetes 1.21. Kubernetes 1.21 started adding a new volume named "kube-api-access-<random-suffix>" and that broke the comparison function and resulted in an infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the incompatibility between the Operator and Kubernetes 1.21.
Kubernetes in 1.21 ships with
BoundServiceAccountTokenVolumeenabled, which causes the service account admission controller to add a new volume:kube-api-access-<random-suffix>. That is causing the operator to loop over comparing the actual and expected volumes. Now that new volume will not be compared.Kubernetes reference: https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/#bound-service-account-token-volume