Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#554 remove deprecated jvm opts #569

Merged
merged 2 commits into from
May 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/v1alpha2/jenkins_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -343,19 +343,19 @@ type JenkinsMaster struct {
// +optional
// Defaults to :
// - name: kubernetes
// version: "1.28.6"
// version: "1.29.4"
// - name: workflow-job
// version: "2.40"
// - name: workflow-aggregator
// version: "2.6"
// - name: git
// version: "4.5.0"
// version: "4.6.0"
// - name: job-dsl
// version: "1.77"
// - name: configuration-as-code
// version: "1.46"
// version: "1.51"
// - name: kubernetes-credentials-provider
// version: "0.15"
// version: "0.18-1"
BasePlugins []Plugin `json:"basePlugins,omitempty"`

// Plugins contains plugins required by user
Expand Down
8 changes: 4 additions & 4 deletions chart/jenkins-operator/crds/jenkins-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ spec:
type: object
basePlugins:
description: 'BasePlugins contains plugins required by operator
Defaults to : - name: kubernetes version: "1.28.6" - name: workflow-job
Defaults to : - name: kubernetes version: "1.29.4" - name: workflow-job
version: "2.40" - name: workflow-aggregator version: "2.6" -
name: git version: "4.5.0" - name: job-dsl version: "1.77" -
name: configuration-as-code version: "1.46" - name: kubernetes-credentials-provider
version: "0.15"'
name: git version: "4.6.0" - name: job-dsl version: "1.77" -
name: configuration-as-code version: "1.51" - name: kubernetes-credentials-provider
version: "0.18-1"'
items:
description: Plugin defines Jenkins plugin.
properties:
Expand Down
18 changes: 9 additions & 9 deletions chart/jenkins-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jenkins:
# image is the name (and tag) of the Jenkins instance
# Default: jenkins/jenkins:lts
# It's recommended to use LTS (tag: "lts") version
image: jenkins/jenkins:2.263.2-lts-alpine
image: jenkins/jenkins:2.277.4-lts-alpine

# env contains jenkins container environment variables
env: []
Expand Down Expand Up @@ -63,34 +63,34 @@ jenkins:
#
# basePlugins:
# - name: kubernetes
# version: 1.29.2
# version: 1.29.4
# - name: workflow-job
# version: "2.40"
# - name: workflow-aggregator
# version: "2.6"
# - name: git
# version: 4.5.0
# version: 4.6.0
# - name: job-dsl
# version: "1.77"
# - name: configuration-as-code
# version: "1.47"
# version: "1.50"
# - name: kubernetes-credentials-provider
# version: 0.15
# version: 0.18-1
basePlugins:
- name: kubernetes
version: "1.29.2"
version: "1.29.4"
- name: workflow-job
version: "2.40"
- name: workflow-aggregator
version: "2.6"
- name: git
version: "4.5.0"
version: "4.6.0"
- name: job-dsl
version: "1.77"
- name: configuration-as-code
version: "1.47"
version: "1.51"
- name: kubernetes-credentials-provider
version: "0.15"
version: "0.18-1"

# plugins are plugins required by the user
# You can define plugins here
Expand Down
8 changes: 4 additions & 4 deletions config/crd/bases/jenkins.io_jenkins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ spec:
type: object
basePlugins:
description: 'BasePlugins contains plugins required by operator
Defaults to : - name: kubernetes version: "1.28.6" - name: workflow-job
Defaults to : - name: kubernetes version: "1.29.4" - name: workflow-job
version: "2.40" - name: workflow-aggregator version: "2.6" -
name: git version: "4.5.0" - name: job-dsl version: "1.77" -
name: configuration-as-code version: "1.46" - name: kubernetes-credentials-provider
version: "0.15"'
name: git version: "4.6.0" - name: job-dsl version: "1.77" -
name: configuration-as-code version: "1.51" - name: kubernetes-credentials-provider
version: "0.18-1"'
items:
description: Plugin defines Jenkins plugin.
properties:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/jenkins.io_v1alpha2_jenkins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
disableCSRFProtection: false
containers:
- name: jenkins-master
image: jenkins/jenkins:2.263.3-lts-alpine
image: jenkins/jenkins:2.277.4-lts-alpine
imagePullPolicy: Always
livenessProbe:
failureThreshold: 12
Expand Down
2 changes: 1 addition & 1 deletion controllers/jenkins_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ func (r *JenkinsReconciler) setDefaults(jenkins *v1alpha2.Jenkins) (requeue bool
changed = true
jenkinsContainer.Env = append(jenkinsContainer.Env, corev1.EnvVar{
Name: constants.JavaOpsVariableName,
Value: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:MaxRAMFraction=1 -Djenkins.install.runSetupWizard=false -Djava.awt.headless=true",
Value: "-XX:MinRAMPercentage=50.0 -XX:MaxRAMPercentage=80.0 -Djenkins.install.runSetupWizard=false -Djava.awt.headless=true",
})
}
if len(jenkins.Spec.Master.BasePlugins) == 0 {
Expand Down
6 changes: 3 additions & 3 deletions deploy/crds/jenkins.io_jenkins_crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ spec:
type: object
basePlugins:
description: 'BasePlugins contains plugins required by operator
Defaults to : - name: kubernetes version: 1.15.7 - name: workflow-job
Defaults to : - name: kubernetes version: 1.29.4 - name: workflow-job
version: "2.39" - name: workflow-aggregator version: "2.6" - name:
git version: 3.10.0 - name: job-dsl version: "1.74" - name: configuration-as-code
version: "1.19" - name: kubernetes-credentials-provider version: 0.12.1'
git version: 4.6.0 - name: job-dsl version: "1.74" - name: configuration-as-code
version: "1.51" - name: kubernetes-credentials-provider version: 0.18-1'
items:
description: Plugin defines Jenkins plugin
properties:
Expand Down
2 changes: 1 addition & 1 deletion deploy/crds/jenkins_v1alpha2_jenkins_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ spec:
master:
containers:
- name: jenkins-master
image: jenkins/jenkins:2.263.2-lts-alpine
image: jenkins/jenkins:2.277.4-lts-alpine
seedJobs:
- id: jenkins-operator
targets: "cicd/jobs/*.jenkins"
Expand Down
10 changes: 5 additions & 5 deletions deploy/crds/jenkins_v1alpha2_jenkinsimage_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@ metadata:
spec:
image:
name: jenkins/jenkins
tag: 2.263.1-lts-alpine
tag: 2.277.4-lts-alpine
plugins:
- name: kubernetes
version: "1.28.6"
version: "1.29.4"
- name: workflow-job
version: "2.40"
- name: workflow-aggregator
version: "2.6"
- name: git
version: "4.5.0"
version: "4.6.0"
- name: job-dsl
version: "1.77"
- name: configuration-as-code
version: "1.46"
version: "1.51"
- name: kubernetes-credentials-provider
version: "0.15"
version: "0.18-1"

3 changes: 1 addition & 2 deletions deploy/crds/openshift_jenkins_v1alpha2_jenkins_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ spec:
value: /var/lib/jenkins
- name: JAVA_OPTS
value: >-
-XX:+UnlockExperimentalVMOptions -XX:+UnlockExperimentalVMOptions
-XX:+UseCGroupMemoryLimitForHeap -XX:MaxRAMFraction=1
-XX:MinRAMPercentage=50.0 -XX:MaxRAMPercentage=80.0
-Djenkins.install.runSetupWizard=false -Djava.awt.headless=true
image: 'quay.io/openshift/origin-jenkins:latest'
imagePullPolicy: Always
Expand Down
2 changes: 1 addition & 1 deletion pkg/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const (
// SeedJobSuffix is a suffix added for all seed jobs
SeedJobSuffix = "job-dsl-seed"
// DefaultJenkinsMasterImage is the default Jenkins master docker image
DefaultJenkinsMasterImage = "jenkins/jenkins:2.263.2-lts-alpine"
DefaultJenkinsMasterImage = "jenkins/jenkins:2.277.4-lts-alpine"
// DefaultHTTPPortInt32 is the default Jenkins HTTP port
DefaultHTTPPortInt32 = int32(8080)
// DefaultSlavePortInt32 is the default Jenkins port for slaves
Expand Down
8 changes: 4 additions & 4 deletions pkg/plugins/base_plugins.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package plugins

const (
configurationAsCodePlugin = "configuration-as-code:1.47"
gitPlugin = "git:4.5.0"
configurationAsCodePlugin = "configuration-as-code:1.51"
gitPlugin = "git:4.6.0"
jobDslPlugin = "job-dsl:1.77"
kubernetesCredentialsProviderPlugin = "kubernetes-credentials-provider:0.15"
kubernetesPlugin = "kubernetes:1.29.0"
kubernetesCredentialsProviderPlugin = "kubernetes-credentials-provider:0.18-1"
kubernetesPlugin = "kubernetes:1.29.4"
workflowAggregatorPlugin = "workflow-aggregator:2.6"
workflowJobPlugin = "workflow-job:2.40"
)
Expand Down