Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push down parameters & methods #562

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 12, 2023

Looking at sources I noticed that a lot of mojo parameters and helper methods were defined in an unnecessarily high superclass (used only in a specific subclass). Trying to push down things into more appropriate places.

Also removing gratuitous getter/setter pattern in favor of simple fields (https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#defining-parameters-within-a-mojo clarifies that the JavaBeans pattern is an option helpful for integrating with other code, which is not relevant in this context) and limiting Java access to private or protected as appropriate.

  • review all members of AbstractJenkinsMojo
  • review all members of AbstractHpiMojo
  • review all members of AbstractJenkinsManifestMojo
  • restore members to original sort order

@jglick jglick added the chore label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant