🚧 Initial attempt to support distributed traces for the cloud lifecycle #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
changed the title
This reverts commit 5ec10da.
…bda: Unexpected exception encountered while provisioning agent'
…bda: Unexpected exception encountered while provisioning agent'
…bda: Unexpected exception encountered while provisioning agent'
v1v
commented
Jul 4, 2021
| */ | ||
| @Extension(dynamicLoadable = YesNoMaybe.YES) | ||
| @Symbol("cloudSpanNamingStrategy") | ||
| public class CloudSpanNamingStrategy { |
| NodeProvisioner.PlannedNode plannedNode = plannedNodes.iterator().next(); | ||
|
|
||
| String rootSpanName = this.cloudSpanNamingStrategy.getRootSpanName(plannedNode); | ||
| JenkinsOpenTelemetryPluginConfiguration.StepPlugin stepPlugin = JenkinsOpenTelemetryPluginConfiguration.get().findStepPluginOrDefault("cloud", cloud.getDescriptor()); |
v1v
commented
Jul 4, 2021
pom.xml
Outdated
| @@ -19,7 +19,7 @@ | |||
| <properties> | |||
| <revision>0.16</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <jenkins.version>2.235.5</jenkins.version> | |||
| <jenkins.version>2.277.1</jenkins.version> | |||
There was a problem hiding this comment.
I'm trying to workaround the issue in my local environment since I get some stacktrace errors:
WARNING hudson.slaves.NodeProvisioner#lambda: Unexpected exception encountered while provisioning agent
So maybe, my machine is too slow that somehow that particular issue happens....
…oner#lambda: Unexpected exception encountered while provisioning agent'" This reverts commit 091504e.
…oner#lambda: Unexpected exception encountered while provisioning agent'" This reverts commit baa08c8.
…oner#lambda: Unexpected exception encountered while provisioning agent'" This reverts commit df3556e.
…r-cloud-provisioning * upstream/master: Support span labels with the plugin details for the SimpleBuildStep implementations (jenkinsci#137)
Require upper bound dependencies error for commons-io:commons-io:2.6 paths to dependency are:
+-io.jenkins.plugins:opentelemetry:0.16-SNAPSHOT
+-org.jenkins-ci.plugins:google-compute-engine:4.3.8
+-commons-io:commons-io:2.6
…r-cloud-provisioning * upstream/master: Explicitly specify the initial git branch name to "master" Because the default git branch name is more frequently set to "main" on development environments [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release opentelemetry-0.16
v1v
force-pushed
the
feature/traces-for-cloud-provisioning
branch
from
5f2490a
to
4f3e52b
Compare
| public static final AttributeKey<String> CI_CLOUD_LABEL = AttributeKey.stringKey("ci.cloud.label"); | ||
| public static final AttributeKey<String> CI_CLOUD_NAME = AttributeKey.stringKey("ci.cloud.name"); | ||
| /** | ||
| * @see <a href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/cloud.md">cloud semantic conventions</a> |
There was a problem hiding this comment.
Would it make sense to create a dedicated class to hold these cloud attributes like OTelCloudSemanticAttributes ? It was misleading for me to see these attributes on the JenkinsOtelSemanticAttributes. I was wondering if we missed the Otel Cloud attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧
What
Given the
CloudProvisioningListenerlet's create specific transactions for the one-shot cloud provisioning.This is just exploring whether it can provide enough context.
OTOH, it uses the same pattern that was done for the build transactions.
Details
UI
K8s workers
Expand to view
GCE workers
Expand to view
Follow ups
2.189.1and I was not able to see the issue. Can we bump the version? I'll probably do at least for this PR to be able to test the whole lifecycle otherwise it will be always reported as failureAWSprovisioner.Tasks
Issues
##95