-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-34474] New parent pom (2.7) #100
Conversation
…sts. Some migrations to JenkinsRule.
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
🐝 Great changes! This was a really difficult upgrade. I'm for closing #97 since it was supposed to be a temporary change for a quick turnaround to get to the parent pom & not change too much in the plugin itself. |
<!-- Ignore animal-sniffer plugin when run with m2e on Eclipse. --> | ||
<plugin> | ||
<groupId>org.eclipse.m2e</groupId> | ||
<artifactId>lifecycle-mapping</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for remove this.
<optional>true</optional> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>matrix-project</artifactId> | ||
<version>1.4</version> | ||
<optional>true</optional> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐝 |
@reviewbybees done |
This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging. |
Close and opening to trigger CI job again. |
@svanoort you still maintaining this? |
@jglick When time permits, yes. But if you're interested in taking over, you're certainly welcome to. |
I am not at all interested. :-) |
Looks like all the checks have passed. Is it possible to get this merged an a new version of the plugin cut today? Anything to get the various test harnesses up and running. |
Superseeds (and includes) #97
Work included:
JenkinsRule
instead ofHudsonTestCase
@reviewbybees @kwhetstone