Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34474] New parent pom (2.7) #100

Merged
merged 4 commits into from
Jun 16, 2016

Conversation

armfergom
Copy link
Contributor

@armfergom armfergom commented Apr 28, 2016

Superseeds (and includes) #97

Work included:

  • Upgrade to parent pom 2.7
  • Fix test errors
  • Fix javadoc errors
  • Update tests to use JenkinsRule instead of HudsonTestCase
  • Bump baseline to 1.596.1. Reason here

@reviewbybees @kwhetstone

@ghost
Copy link

ghost commented Apr 28, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kwhetstone
Copy link
Contributor

🐝 Great changes! This was a really difficult upgrade. I'm for closing #97 since it was supposed to be a temporary change for a quick turnaround to get to the parent pom & not change too much in the plugin itself.

<!-- Ignore animal-sniffer plugin when run with m2e on Eclipse. -->
<plugin>
<groupId>org.eclipse.m2e</groupId>
<artifactId>lifecycle-mapping</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remove this.

<optional>true</optional>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>matrix-project</artifactId>
<version>1.4</version>
<optional>true</optional>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresrc
Copy link

🐝

@armfergom
Copy link
Contributor Author

@reviewbybees done

@ghost
Copy link

ghost commented May 3, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@armfergom armfergom closed this Jun 15, 2016
@armfergom
Copy link
Contributor Author

Close and opening to trigger CI job again.

@armfergom armfergom reopened this Jun 15, 2016
@jglick
Copy link
Member

jglick commented Jun 15, 2016

@svanoort you still maintaining this?

@svanoort
Copy link
Member

@jglick When time permits, yes. But if you're interested in taking over, you're certainly welcome to.

@jglick
Copy link
Member

jglick commented Jun 15, 2016

I am not at all interested. :-)

@kwhetstone
Copy link
Contributor

Looks like all the checks have passed. Is it possible to get this merged an a new version of the plugin cut today? Anything to get the various test harnesses up and running.

@svanoort svanoort merged commit e20816f into jenkinsci:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants