Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support env vars to define filePattern of FileBuildParameterFactory #147

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Support env vars to define filePattern of FileBuildParameterFactory #147

merged 1 commit into from
Aug 26, 2021

Conversation

gjabouley-invn
Copy link
Contributor

Enable support of environment variables to define filePattern of FileBuildParameterFactory (for every property file, invoke one build)

image

@gjabouley-invn gjabouley-invn changed the title Enable support of environment variable to define filePattern of FileB… Support env vars to define filePattern of FileBuildParameterFactory Oct 8, 2020
@gjabouley-invn
Copy link
Contributor Author

gjabouley-invn commented Oct 8, 2020

Not sure those checks failures are related to the current change.

Reg. Jenkins builds:

  • Test suite hudson.plugins.parameterizedtrigger.test.NodeParametersTest does not timeout on my dev machine.
  • Probably subsequent failure is due to above timeout

Reg. Github windows builds:

  • Error indicates an infrastructure/VM issue
    jenkins.util.io.CompositeIOException: Unable to delete 'D:\a\parameterized-trigger-plugin\parameterized-trigger-plugin\target\tmp\j h3559511358209244089'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

@gjabouley-invn
Copy link
Contributor Author

gjabouley-invn commented Oct 8, 2020

After forcing a rebuild, only Github CI windows builds are failing with same errors (cannot delete some files)

@gjabouley-invn
Copy link
Contributor Author

Can this simple change be merged and included in next plugin release?
Just rebased it on top of latest master

Some tests on Windows build are failing because of a cryptic error, probably not related to this change:
java.io.IOException: Agent failed to connect, even though the launcher didn't report it. See the log output for details.

…uildParameterFactory (for every property file, invoke one build
@gjabouley-invn
Copy link
Contributor Author

Hi @olamy, i have rebased the change, i think it is ready to merge and provides a reasonably simple but useful enhancement.
Thanks

@olamy olamy merged commit d2ea3a8 into jenkinsci:master Aug 26, 2021
@gjabouley-invn gjabouley-invn deleted the feature/add_support_for_envvars_to_define_filebuildparametersfactory_filepattern branch August 27, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants