Fix Null pointer exceptions #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @olamy |
oleg-nenashev
approved these changes
Jan 2, 2021
| listener.getLogger().println("Skipping " + HyperlinkNote.encodeTo('/'+ p.getUrl(), p.getFullDisplayName()) + | ||
| ". The project is either disabled," | ||
| + " or the authenticated user " + ModelHyperlinkNote.encodeTo(User.current()) + " has no Item.BUILD permissions," | ||
| + " or the authenticated user " + userName + " has no Item.BUILD permissions," |
There was a problem hiding this comment.
"the authenticated user unknown has no ..." is a bit odd, but should be ok
There was a problem hiding this comment.
It should be the authenticated user unknown has no Item.BUILD
| @@ -151,7 +154,10 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, | |||
| BuildInfoExporterAction.addBuildInfoExporterAction(build, completedRun.getParent().getFullName(), completedRun.getNumber(), completedRun.getResult()); | |||
|
|
|||
| if (buildStepResult && config.getBlock().mapBuildStepResult(completedRun.getResult())) { | |||
| build.setResult(config.getBlock().mapBuildResult(completedRun.getResult())); | |||
| Result r = config.getBlock().mapBuildResult(completedRun.getResult()); | |||
| if (r != null) { | |||
There was a problem hiding this comment.
r == null when the run is not finished.
Maybe it makes sense to add a system warning for the edge case
There was a problem hiding this comment.
Sure I can add it in case there is some underlying issue here
hashar
added a commit
to hashar/parameterized-trigger-plugin
that referenced
this pull request
Apr 10, 2024
I keep having log messages such as: WARNING: [hudson.plugins.parameterizedtrigger.TriggerBuilder perform] Attempting to use the result of unfinished build <name of job> #1234 The message was introduced in jenkinsci#161 by 06d8f19 but in jenkinsci#148 / 02ee6ea, mapBuildResult() was made to return `null` by default (eg on SUCCESS). The resut is the warning is always triggered when the triggered build succeeds. Fixes https://phabricator.wikimedia.org/T336782
MarkEWaite
added a commit
that referenced
this pull request
May 7, 2024
I keep having log messages such as: WARNING: [hudson.plugins.parameterizedtrigger.TriggerBuilder perform] Attempting to use the result of unfinished build <name of job> #1234 The message was introduced in #161 by 06d8f19 but in #148 / 02ee6ea, mapBuildResult() was made to return `null` by default (eg on SUCCESS). The resut is the warning is always triggered when the triggered build succeeds. Fixes https://phabricator.wikimedia.org/T336782 Co-authored-by: Mark Waite <[email protected]> Co-authored-by: Bruno Verachten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also prevent https://issues.jenkins.io/browse/JENKINS-64502?focusedCommentId=402814&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-402814
Drops the number of spotbugs to 4 from 10