Add spotbugs exclusions

[dheerajodha]

This PR simply updates the parent POM of this plugin from 4.31 to 4.33.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did

[jglick]

Diff is much longer than it needs to be, but if the formatting changes were reverted I think this would be good.

[jglick]

https://github.com/jenkinsci/parameterized-trigger-plugin/pull/235/checks?check_run_id=5243312168 smells like a too-aggressive timeout?

[jglick]

Thanks!

[dheerajodha]

https://github.com/jenkinsci/parameterized-trigger-plugin/pull/235/checks?check_run_id=5243312168 smells like a too-aggressive timeout?

I tried to see what the error was:

Condition with lambda expression in hudson.plugins.parameterizedtrigger.test.BuildTriggerTest that uses hudson.model.FreeStyleProject was not fulfilled within 10 seconds.

But now it is resolved, and all I did was undo the autoformatting done by IDE. I'm confused about what went wrong and how it got resolved...

[jglick]

Probably just some flaky test unrelated to your PR.

[olamy]

as recommended here https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
can you change to later releases within an LTS line? 2.289.3
thanks

[jglick]

The current PR matches the currently documented advice, but FWIW there is no real consensus here. See jenkins-infra/jenkins.io#4876

[dheerajodha]

Thanks for your comments!
Lmk if we mutually decide to change jenkins.version be 2.289.3. I'm keeping it as 2.289.1 for now, unless Olivier has something to add.

[jglick]

Note that extending Plugin is deprecated.

parameterized-trigger-plugin/src/main/java/hudson/plugins/parameterizedtrigger/Plugin.java

Lines 31 to 32 in 5923a07

	Stapler.CONVERT_UTILS.register(new EnumConverter(),
	ResultCondition.class);

could be made into an @Initializer, though it could probably simply be a static initializer in ResultCondition.java.

[dheerajodha]

I understood that extending Plugin is deprecated.
Can you please help me in understanding what is our concern with Stapler.CONVERT_UTILS.register and how would that be addressed by making it into an @Initializer?

I read about CONVERT_UTILS from its javadocs and since ResultCondition is an enum, maybe we are trying to register it so that it becomes easier for Stapler to bind the enum constants...?

[jglick]

I suppose so. I would have expected any enum to be handled automatically by Stapler without a special call; maybe it is, and this call is just obsolete. Not sure offhand if it works to just move this to a static block in ResultCondition; I am guessing the key is whether ResultCondition would already have been loaded for some other reason by the time someone saves a configure page involving a value of this enum in some field and Jenkins starts processing a doSubmitConfigXml method with a JSON payload. An @Initializer is the more direct replacement and conservative fix, though it always runs whether or not you are even using this plugin. Whether this has any effective test coverage is another question (typically something calling configRoundtrip).

[jglick]

(To be clear, this is just an aside about an existing deprecated API, certainly not something that needs to be changed in this PR.)

[dheerajodha]

Thanks for the detailed info! This makes things little bit more clear to me now.

Minimum Jenkins version has been updated in other pull requests. Thanks for raising the concern. It has been resolved.