Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress spotbugs errors #278

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

jmMeessen
Copy link
Contributor

@jmMeessen jmMeessen commented Aug 25, 2022

This plugin will be used the DW2022 Contributing Workshop. In order to keep the focus of trainees, I propose to suppress the spotbugs errors. The compile will not have impressive warnings and the CI job has more chances to run successfully.

Suppressed warnings are stored in the suppressed-spotbug-errors.xml file

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@jmMeessen jmMeessen added chore maintenance java Pull requests that update Java code labels Aug 25, 2022
@jmMeessen jmMeessen marked this pull request as draft August 25, 2022 13:53
@jmMeessen jmMeessen marked this pull request as ready for review August 25, 2022 14:14
@MarkEWaite MarkEWaite changed the title Suppressing spotbugs errors for training purposes Suppressing spotbugs errors Aug 25, 2022
@MarkEWaite MarkEWaite changed the title Suppressing spotbugs errors Suppress spotbugs errors Aug 25, 2022
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MarkEWaite MarkEWaite merged commit f44fff1 into jenkinsci:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore java Pull requests that update Java code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants