Provide a default value of jenkins.addOpens for the benefit of IDEs
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ IDEA is not able to run our custom Maven lifecycle mapping from
maven-hpi-plugin(which includes atest-runtimemojo that configuresjenkins.addOpensandjenkins.insaneHook), but as of JetBrains/intellij-community#1976 it will be able to do late replacement of properties inargLinefrom the parent POM. This PR adds a default value ofjenkins.addOpensfor such cases. In the Maven build thetest-runtimemojo will always fill this in with the correct value fromjenkins.war, but this PR allows IDE builds to degrade gracefully to a setting that should work most of the time (as long as the default value specified here doesn't diverge too much from the one shipped injenkins.war). To test this PR, I ranorg.jenkinsci.plugins.workflow.job.WorkflowRunTest#parametersin IDEA with my changes from JetBrains/intellij-community#1976; prior to this PR it failed and with this PR it used the new default value and passed.