Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default value of jenkins.addOpens for the benefit of IDEs #529

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 2, 2022

IntelliJ IDEA is not able to run our custom Maven lifecycle mapping from maven-hpi-plugin (which includes a test-runtime mojo that configures jenkins.addOpens and jenkins.insaneHook), but as of JetBrains/intellij-community#1976 it will be able to do late replacement of properties in argLine from the parent POM. This PR adds a default value of jenkins.addOpens for such cases. In the Maven build the test-runtime mojo will always fill this in with the correct value from jenkins.war, but this PR allows IDE builds to degrade gracefully to a setting that should work most of the time (as long as the default value specified here doesn't diverge too much from the one shipped in jenkins.war). To test this PR, I ran org.jenkinsci.plugins.workflow.job.WorkflowRunTest#parameters in IDEA with my changes from JetBrains/intellij-community#1976; prior to this PR it failed and with this PR it used the new default value and passed.

@basil basil added the bug label Apr 2, 2022
@basil basil merged commit 240d139 into jenkinsci:master Apr 2, 2022
@basil basil deleted the intellij branch April 2, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants