[CID-152201] - Fix resource leak in remoting.jnlp.Main #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| final int read; | ||
| try { | ||
| read = fis.read(cert); | ||
| } finally { |
|
🐝 |
|
@reviewbybees done |
oleg-nenashev
added a commit
that referenced
this pull request
Sep 26, 2016
* [maven-release-plugin] prepare release remoting-2.62 * [maven-release-plugin] prepare for next development iteration * [FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty (#101) Bug diagnosis: * https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427367&mergedDefectId=152195 * https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427365&mergedDefectId=152194 * [CID-152201] - Fix resource leak in remoting.jnlp.Main (#102) * [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths (#104) * [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths * https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836377&defectInstanceId=4427377&mergedDefectId=152202 * https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836377&defectInstanceId=4427377&mergedDefectId=152200 * [CID-152202] - Fix typo noticed by @olivergondza * Fix another merge conflict * Remove EngineUtil#closeAndLogFailures()
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Oct 9, 2016
2.61 does not exist, there was an issue during the release Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622 * [JENKINS-38539](https://issues.jenkins-ci.org/browse/JENKINS-38539) - Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again. (jenkinsci/remoting#110) * [JENKINS-37539](https://issues.jenkins-ci.org/browse/JENKINS-37539) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. (jenkinsci/remoting#101) * [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. (jenkinsci/remoting#102) * [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. (jenkinsci/remoting#104)
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Oct 11, 2016
…2585) 2.61 does not exist, there was an issue during the release Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622 * [JENKINS-38539](https://issues.jenkins-ci.org/browse/JENKINS-38539) - Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again. (jenkinsci/remoting#110) * [JENKINS-37539](https://issues.jenkins-ci.org/browse/JENKINS-37539) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. (jenkinsci/remoting#101) * [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. (jenkinsci/remoting#102) * [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. (jenkinsci/remoting#104)
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Nov 6, 2016
This PR picks the latest available version of remoting stable-2.x. All the fixes have been integrated into remoting-3.0 and soaked enough. * [JENKINS-38539](https://issues.jenkins-ci.org/browse/JENKINS-38539) - Stability: Turn on SO_KEEPALIVE by default and provide CLI option to turn it off again. (jenkinsci/remoting#110) * [JENKINS-37539](https://issues.jenkins-ci.org/browse/JENKINS-37539) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. (jenkinsci/remoting#101) * [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. (jenkinsci/remoting#102) * [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. (jenkinsci/remoting#104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836384&defectInstanceId=4427348&mergedDefectId=152201
@reviewbybees