Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37567] - Add option to specify certchain, enforce certificate checks #190

Merged

Conversation

oleg-nenashev
Copy link
Member

It should finalize JENKINS-37567.

I have checked the default options, the change does not impact the local dev build and @kohsuke 's release flow. I am quite aware about the jarsigner -tsa step in the release profile, but it seems to be harmless on my local machine.

@reviewbybees @olamy @kohsuke

<processAttachedArtifacts>false</processAttachedArtifacts>
<certs>true</certs>
<errorWhenNotSigned>true</errorWhenNotSigned>
<arguments>-strict</arguments> <!--otherwise certificate chains will be ignored-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamy Likely I should create a MJARSIGNER issue for adding this parameter. I would argue it should be enabled by default in Java's jarsigner or in at least Maven JarSigner Plugin, but it would be a potentially breaking change

@ghost
Copy link

ghost commented Aug 18, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link

@alexanderrtaylor alexanderrtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
🐝

@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev
Copy link
Member Author

Merging in order to proceed with the release

@oleg-nenashev oleg-nenashev merged commit ca48837 into jenkinsci:master Aug 18, 2017
Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐝 Sorry for the delay @oleg-nenashev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants