Annotate ChannelBuilder#header #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Jun 13, 2018
There was a problem hiding this comment.
Fine but is not the reason for my objection to the core PR. You are demonstrating that
OutputStream headerStream = cb.getHeaderStream();
if (headerStream == null) {is a legitimate null check. I pointed out that if you fail to then set the local variable to a non-null value, you will be calling setChannel(Channel, null, Channel.Listener), which will then call new StreamTaskListener(null), which will then call new PrintStream(null, false), which will throw NPE from requireNonNull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a follow-up to @jglick 's review comment in jenkinsci/jenkins#3489
Nulls are fine according to the logic