Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reloading configuration from disk #545

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Fix reloading configuration from disk #545

merged 4 commits into from
Nov 27, 2023

Commits on Nov 23, 2023

  1. Fix reloading configuration from disk 

    This makes the `load()` method work properly when called after startup, in
case of a reload configuration from disk for example.

Functionally, the `reconfigure()` method needs to be called implicitly when calling
`load()`, because it updates a snapshot state that is used by running builds.
If the persisted state has changed on disk then loaded, the snapshot needs to be updated accordingly.

Without this patch, the `ScriptApproval` state is correct, but anything
that has changed since last time it was loaded is not reflected on
running builds.
    @Vlatombe
    Vlatombe committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0899757 View commit details
    Browse the repository at this point in the history

  2. Fix milestone and add logging

    @Vlatombe
    Vlatombe committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fc513f0 View commit details
    Browse the repository at this point in the history

  3. Relax the log check

    @Vlatombe
    Vlatombe committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2ddc35a View commit details
    Browse the repository at this point in the history

  4. Clean up unused import

    @Vlatombe
    Vlatombe committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ed5b0bf View commit details
    Browse the repository at this point in the history