Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

white list java.time.format.DateTimeFormatter parse method #571

Merged

Conversation

pgermosen
Copy link
Contributor

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This change is similar to instant parse change the reasoning, we have the static fields of DateTimeFormatter that was added in subset of the Java 8 time API, but we cannot use the class, because it is not whitelisted to the instance methods.

java.time package, is a safe API that use immutable classes, so it should be safe to use it.

@pgermosen pgermosen requested a review from a team as a code owner July 10, 2024 15:05
@jglick jglick merged commit 82a9de4 into jenkinsci:master Aug 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants