Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JenkinsWhitelistTest on 2.477 incremental #578

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 14, 2024

Fix JenkinsWhitelistTest test on 2.477 incremental

The JenkinsWhitelistTest will fail because

method hudson.model.Run getFullDisplayName does not exist (or is an override)

Uses the same technique as was used in:

Downstream of:

Testing done

Confirmed that the test fails when run with Jenkins incremental. Failure is also visible in plugin BOM at jenkinsci/bom#3574

  • Shows the test failure on ci.jenkins.io as build 1.
  • Shows the fix passes the test failure on ci.jenkins.io as build 2.
  • Shows the fix passes on older versions of Jenkins core in build 3

A release of the plugin with this test fix is needed before the plugin BOM can adopt Jenkins 2.477. Jenkins 2.477 is scheduled for release Tuesday 17 Sep 2024 and is a possible candidate as the next LTS baseline (for 30 Oct 2024 release).

@jglick could you review, approve, and merge this fix?

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The JenkinsWhitelistTest will fail because

  method hudson.model.Run getFullDisplayName does not exist (or is an override)

Show the test failure on ci.jenkins.io,
@MarkEWaite MarkEWaite marked this pull request as ready for review September 14, 2024 04:37
@rsandell rsandell merged commit 67dc1f0 into jenkinsci:master Sep 16, 2024
16 checks passed
@MarkEWaite MarkEWaite deleted the fix-failing-test-in-plugin-bom branch September 16, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants