Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[JENKINS-72690] Make the widget sticky (#287)" #311

Closed
wants to merge 1 commit into from

Conversation

hashar
Copy link
Contributor

@hashar hashar commented Oct 29, 2024

When other panels have been added to the side bar, they are shown overlapping with the stick timestamper panel which has a transparent background. That is noticeable with the Collapsible Section plugin which can generate a fairly long panel. That was reported by @mPokornyETM on jenkinsci/collapsing-console-sections-plugin#35 (comment):

image

I understand the use case for making it sticky when the plugin is used by itself, but the overlapping text is concerning.

This reverts commit b2e06b5.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

When other panels have been added to the side bar, they are shown
overlapping with the stick timestamper panel which has a transparent
background.  That is noticeable with the Collapsible Section plugin
which can generate a fairly long panel.

I understand the use case for making it sticky, but the overlapping text
is concerning.

This reverts commit b2e06b5.
@hashar
Copy link
Contributor Author

hashar commented Oct 31, 2024

I think I got it solved by making the Collapsing Console Section panel to also be sticky. jenkinsci/collapsing-console-sections-plugin#35 (comment)

I am closing for now.

@hashar hashar closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant