Merge pull request #1631 from jenkinsci/ctor-exception-spotbugs

Remove suppress warnings: ctor rule has been disabled globally
jenkinsci · Nov 29, 2023 · 620edb9 · 620edb9
2 parents 5574bf7 + c07917a
commit 620edb9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/plugin/pom.xml b/plugin/pom.xml
@@ -4,7 +4,7 @@
   <parent>
     <groupId>org.jvnet.hudson.plugins</groupId>
     <artifactId>analysis-pom</artifactId>
-    <version>6.15.0</version>
+    <version>6.16.0</version>
     <relativePath />
   </parent>
 

diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/PublishIssuesStep.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/PublishIssuesStep.java
@@ -854,7 +854,6 @@ static class Execution extends AnalysisExecution<ResultAction> {
          *         the actual step to execute
          */
         @SuppressWarnings("PMD.AvoidLiteralsInIfCondition")
-        @SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if no reports are provided")
         Execution(@NonNull final StepContext context, final PublishIssuesStep step) {
             super(context);
 

diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RegisteredParser.java b/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RegisteredParser.java
@@ -11,7 +11,6 @@
 import edu.hm.hafner.analysis.registry.ParserRegistry;
 import edu.hm.hafner.util.VisibleForTesting;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.verb.POST;
@@ -45,7 +44,6 @@ public class RegisteredParser extends ReportScanningTool {
      *         the unique ID of the tool in the analysis-model module
      */
     @DataBoundConstructor
-    @SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if parser is not found")
     public RegisteredParser(final String analysisModelId) {
         super();
 

diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RevApi.java b/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RevApi.java
@@ -8,7 +8,6 @@
 import edu.hm.hafner.analysis.Issue;
 import edu.hm.hafner.analysis.Report;
 import edu.hm.hafner.analysis.RevApiInfoExtension;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.jenkinsci.Symbol;
@@ -151,7 +150,6 @@ public static class RevApiRow extends TableRow {
             private final String severity;
             private String category;
 
-            @SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if wrong type has been passed")
             RevApiRow(final AgeBuilder ageBuilder, final FileNameRenderer fileNameRenderer,
                     final DescriptionProvider descriptionProvider, final Issue issue,
                     final JenkinsFacade jenkinsFacade, final Serializable additionalData) {