-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump io.jenkins.plugins:analysis-model-api from 11.6.0 to 11.13.0 #1619
Bump io.jenkins.plugins:analysis-model-api from 11.6.0 to 11.13.0 #1619
Conversation
Bumps [io.jenkins.plugins:analysis-model-api](https://github.com/jenkinsci/analysis-model) from 11.6.0 to 11.13.0. - [Release notes](https://github.com/jenkinsci/analysis-model/releases) - [Changelog](https://github.com/jenkinsci/analysis-model/blob/main/CHANGELOG.md) - [Commits](jenkinsci/analysis-model@v11.6.0...v11.13.0) --- updated-dependencies: - dependency-name: io.jenkins.plugins:analysis-model-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Hello @uhafner I have looked into this test failure And I have found that the issue comes from [these lines](jenkinsci/analysis-model@v11.7.0...v11.13.0#:~:text=else%20if%20(line,%7D) which make the warnings-ng show 4 issues instead of 2 and thus failing with the below error message. When running the test I saw that the generated console log for the job is the same in both cases, and the Maven errors are the same (with and without these lines) , the difference is if they are shown or not in warnings-ng, and the choice of taking them into account or not is based on whether the goal is reset or not ( So far, I see 2 possibilities:
Could I have your opinion on this please? What would be the best approach?
|
….jenkins.plugins-analysis-model-api-11.13.0
The tests are wrong now, since the parser now correctly handles Maven errors as well. I fixed the test right now! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1619 +/- ##
=========================================
Coverage 81.81% 81.81%
Complexity 1411 1411
=========================================
Files 249 249
Lines 5357 5357
Branches 397 397
=========================================
Hits 4383 4383
Misses 861 861
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Thanks Ulli! |
Thank you! |
Hello @uhafner |
Why does a security scan detect a problem in the warnings plugin? This PR just increases the minimum dependency for the analysis-model. This seems to be a bug of the security scanner? |
There is a problem with the PCT messing up some test dependency when we purely try to bump |
Bumps io.jenkins.plugins:analysis-model-api from 11.6.0 to 11.13.0.
Release notes
Sourced from io.jenkins.plugins:analysis-model-api's releases.
... (truncated)
Commits
a83e358
[maven-release-plugin] prepare release v11.13.0a307584
Remove disable nexus step.6ef26ec
[maven-release-plugin] prepare for next development iteration3374836
[maven-release-plugin] prepare release v11.12.04469421
Use ossrh for deployments.c8fd1cb
Merge pull request #966 from jenkinsci/dependabot/maven/org.jsoup-jsoup-1.16.204cf532
Merge pull request #967 from jenkinsci/dependabot/maven/edu.hm.hafner-codings...41cb607
Bump edu.hm.hafner:codingstyle-pom from 3.33.0 to 3.35.04792183
Bump org.jsoup:jsoup from 1.16.1 to 1.16.222debff
Do not updatenet.javacrumbs.json-unit:json-unit-assertj
(Java 17).Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)