-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability of publishIssues
to run without a workspace
#1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jglick
commented
Apr 11, 2024
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/PublishIssuesStepTest.java
Outdated
Show resolved
Hide resolved
amuniz
approved these changes
Apr 12, 2024
BuildWatcher doesn't seem to be supported yet in Junit5 execution mode so removed it.
Follow-up fixing arch rules
Vlatombe
approved these changes
Apr 12, 2024
…ally but `checkstyle:check` passes locally despite failing in CI)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1727 +/- ##
============================================
- Coverage 82.50% 82.45% -0.06%
+ Complexity 1349 1348 -1
============================================
Files 248 248
Lines 5208 5209 +1
Branches 400 401 +1
============================================
- Hits 4297 4295 -2
- Misses 804 806 +2
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
uhafner
approved these changes
Apr 15, 2024
Moved in 4efc2dc FTR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a recent regression #1669 (comment) #1679 (comment) because
warnings-ng-plugin/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/PublishIssuesStep.java
Lines 451 to 454 in 095ef11
Without fix, test fails as observed in a real controller:
Error