Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with job-dsl and maven plugin versions from BOM #1837

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

MarkEWaite
Copy link
Contributor

Test with job-dsl and maven plugin versions from BOM

Since the plugin bill of materials includes those plugin versions, let's use them in the test configuration rather than declaring them explicitly and then maintaining them with dependabot updates.

Should not change the runtime dependencies in any way, since they are purely test dependencies.

Supersedes:

Testing done

Confirmed that automated tests pass in the plugin module that includes the change.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Since the plugin bill of materials includes those plugin versions, let's
use them in the test configuration rather than declaring them explicitly
and then maintaining them with dependabot updates.

Should not change the runtime dependencies in any way, since they are
purely test dependencies.
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (bcfd383) to head (e5fcd7a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1837      +/-   ##
============================================
- Coverage     82.66%   82.53%   -0.14%     
+ Complexity     1362     1359       -3     
============================================
  Files           249      249              
  Lines          5233     5233              
  Branches        402      402              
============================================
- Hits           4326     4319       -7     
- Misses          798      804       +6     
- Partials        109      110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the dependencies Update of dependencies label Sep 22, 2024
@uhafner
Copy link
Member

uhafner commented Sep 22, 2024

Thanks for spotting!

@uhafner uhafner merged commit 28a3514 into jenkinsci:main Sep 22, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants