Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73896] Un-inline JavaScript in ResultAction/summary.jelly #1862

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin commented Oct 15, 2024

JENKINS-73896

Testing done

Tested against a sample project that intentionally has code violations (https://github.com/yaroslavafenkin/bad-project). In job config I've added Record compiler warnings and static analysis results post-build action, added PMD and Checkstyle static analysis tools. In advanced section I've added a quality gate and set the threshold to 3.

https://www.loom.com/share/423b4f0b70584ca5b8bf2f912dc5f849?sid=e77eb4c4-969a-42ee-8e12-df9ebdba0687

https://www.loom.com/share/0294d526ad0e439fafc7106e271716d6?sid=0d659442-3a37-4579-b49b-9a0c83b19f5b

CSP violations that still appear in the "after" video are then ones that are fixed by jenkinsci/echarts-api-plugin#357.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (e659c7a) to head (9b9eb13).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1862   +/-   ##
=========================================
  Coverage     82.57%   82.57%           
  Complexity     1360     1360           
=========================================
  Files           249      249           
  Lines          5233     5233           
  Branches        402      402           
=========================================
  Hits           4321     4321           
  Misses          802      802           
  Partials        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the internal Internal changes without user or API impact label Oct 15, 2024
@uhafner uhafner merged commit 8c94cd2 into jenkinsci:main Oct 16, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants