[JENKINS-73896] Un-inline JavaScript in ResultAction/summary.jelly #1862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73896
Testing done
Tested against a sample project that intentionally has code violations (https://github.com/yaroslavafenkin/bad-project). In job config I've added Record compiler warnings and static analysis results post-build action, added PMD and Checkstyle static analysis tools. In advanced section I've added a quality gate and set the threshold to 3.
https://www.loom.com/share/423b4f0b70584ca5b8bf2f912dc5f849?sid=e77eb4c4-969a-42ee-8e12-df9ebdba0687
https://www.loom.com/share/0294d526ad0e439fafc7106e271716d6?sid=0d659442-3a37-4579-b49b-9a0c83b19f5b
CSP violations that still appear in the "after" video are then ones that are fixed by jenkinsci/echarts-api-plugin#357.
Submitter checklist