Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73959] Use CSP compatible version of st:bind in PullRequestMonitoringPortlet/monitor.jelly #1868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaroslavafenkin
Copy link
Contributor

https://issues.jenkins.io/browse/JENKINS-73959

Testing done

Requires https://plugins.jenkins.io/pull-request-monitoring/ to be installed. I've set up a multibranch project, because that's the only supported project type according to https://plugins.jenkins.io/pull-request-monitoring/#plugin-content-prerequisites.
Also used https://plugins.jenkins.io/github-branch-source/ as branch source for the project. Repo I've used as the source is https://github.com/yaroslavafenkin/bad-project.

Before the change

After the change

Other CSP violations that appear in the video come from https://github.com/jenkinsci/pull-request-monitoring-plugin/blob/d602c91131a8112eef8cc9d00aee013f4443a307/src/main/resources/io/jenkins/plugins/monitoring/MonitoringDefaultAction/index.jelly#L60 and https://plugins.jenkins.io/muuri-api/ which is the dependency of Pull Request Monitoring.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (da7e0e8) to head (b0031b8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1868      +/-   ##
============================================
+ Coverage     82.62%   82.66%   +0.03%     
- Complexity     1365     1366       +1     
============================================
  Files           249      249              
  Lines          5243     5243              
  Branches        402      402              
============================================
+ Hits           4332     4334       +2     
+ Misses          801      799       -2     
  Partials        110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants