Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63782] Ignore case when comparing paths on Windows #767

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jan 31, 2021

Replace handmade path comparison with Path.startsWith. Should fix the path detection problems on Windows (case insensitive paths).

See JENKINS-63782

Should fix the path detection problems on Windows (case insensitve paths).
See https://issues.jenkins.io/browse/JENKINS-63782.
@uhafner uhafner added the bug Bugs or performance problems label Jan 31, 2021
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #767 (4ea2ea9) into master (d819bd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #767   +/-   ##
=========================================
  Coverage     80.04%   80.04%           
  Complexity     1549     1549           
=========================================
  Files           243      243           
  Lines          5627     5628    +1     
  Branches        416      416           
=========================================
+ Hits           4504     4505    +1     
  Misses          967      967           
  Partials        156      156           
Impacted Files Coverage Δ Complexity Δ
...gins/analysis/core/util/AffectedFilesResolver.java 91.83% <100.00%> (+0.17%) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d819bd7...4ea2ea9. Read the comment docs.

@uhafner uhafner merged commit 62ef367 into master Feb 1, 2021
@uhafner uhafner deleted the ignore-case-windows-path branch February 1, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant