Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required repository sections to example pom #864

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

ClaytonHughes
Copy link
Contributor

Without these, maven cannot find the parent pom. Thought I'd offer an update to the documentation to fix that problem.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
    • I have no desired changelog entry. I don't really care, just thought I'd help.
  • Please describe what you did
    • I added the <repository> and <pluginRepository> sections required to get the provided pom to work.
  • Link to relevant issues in GitHub or Jira
    • No issue, I just found it and fixed it.
  • Link to relevant pull requests, esp. upstream and downstream changes
    • N/A
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue
    • Tests for a documentation change?

Without these, maven cannot find the parent pom. Thought I'd offer an update to the documentation to fix that problem.
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #864 (d5723b0) into master (4e69053) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head d5723b0 differs from pull request most recent head bcac74a. Consider uploading reports for the commit bcac74a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #864      +/-   ##
============================================
+ Coverage     80.17%   80.20%   +0.03%     
  Complexity     1561     1561              
============================================
  Files           243      243              
  Lines          5664     5664              
  Branches        422      422              
============================================
+ Hits           4541     4543       +2     
+ Misses          966      965       -1     
+ Partials        157      156       -1     
Impacted Files Coverage Δ Complexity Δ
...s/plugins/analysis/core/model/ReportXmlStream.java 94.73% <0.00%> (+5.26%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e69053...bcac74a. Read the comment docs.

doc/Custom-Plugin.md Outdated Show resolved Hide resolved
doc/Custom-Plugin.md Outdated Show resolved Hide resolved
@uhafner uhafner added the documentation Enhancement of documentation label Apr 1, 2021
<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>

@uhafner uhafner merged commit e6f0b7a into jenkinsci:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhancement of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants