Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: java 17 authentication #42

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: java 17 authentication #42

merged 3 commits into from
Sep 8, 2023

Conversation

butchyyyy
Copy link
Collaborator

In Java 17, the authenticator is invoked with SERVER requestor even when the initial request is performed and even tho we provide the preemptive authorization via header.

Since our authenticator implementaiton did not provide credentials for SERVER requestor, only for PROXY, the message sending would crash with java.io.IOException: No credentials provided error.

Fixes #40

Testing done

Submitter checklist

@butchyyyy butchyyyy merged commit abefee5 into master Sep 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No credentials provided - after upgrading to version 2
1 participant