Skip to content

Commit

Permalink
"fix" broken tests
Browse files Browse the repository at this point in the history
This is not a real fix, it just masks the problem. View queries are not parsed correctly in the ParseViewQuery function. AST cannot be built in some cases. However, we didn't report AST building error as a failure previously, because we are using only the query text, not the AST. We have fixed the parsing in the other commit (see ydb-platform#9860).
  • Loading branch information
jepett0 committed Oct 14, 2024
1 parent ee00dd5 commit 10b3d30
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions ydb/library/yql/sql/v1/sql_query.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1105,13 +1105,9 @@ bool TSqlQuery::Statement(TVector<TNodePtr>& blocks, const TRule_sql_stmt_core&

std::map<TString, TDeferredAtom> features;
if (node.HasBlock4()) {
if (!ParseObjectFeatures(features, node.GetBlock4().GetRule_create_object_features1().GetRule_object_features2())) {
return false;
}
}
if (!ParseViewQuery(features, node.GetRule_select_stmt6())) {
return false;
ParseObjectFeatures(features, node.GetBlock4().GetRule_create_object_features1().GetRule_object_features2());
}
ParseViewQuery(features, node.GetRule_select_stmt6());

const TString objectId = Id(node.GetRule_object_ref3().GetRule_id_or_at2(), *this).second;
constexpr const char* TypeId = "VIEW";
Expand Down

0 comments on commit 10b3d30

Please sign in to comment.