Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Code Runner #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thehamzaihsan
Copy link

Added support for coderunner. I currently only have a linux machine but I'll try adding support for MacOs and Windows. If you find anything wrong in the PR please make sure to let me know about it.

Btw if the mod is reading this: Thank you so much for this repo, I am on linux and my university only allows MASM, so this is a great help. Thanks alot.

@thehamzaihsan thehamzaihsan changed the title Explained Support for Code Runner Added Support for Code Runner Mar 31, 2024
@thehamzaihsan
Copy link
Author

Tested on Friends Macbook and it works there too 🎉.

Copy link
Owner

@jere-mie jere-mie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, and I'm glad you found easy-masm helpful :)

I've just added some suggested changes.

PS. I'm thrilled to see people around the world using easy-masm. Please feel free to send this repo to your colleagues as well as your professor. My university now incorporates easy-masm into the curriculum of our assembly class, and yours could too. It makes life much better on the future students who take this class.

docs/coderunner.md Outdated Show resolved Hide resolved
docs/coderunner.md Outdated Show resolved Hide resolved
docs/coderunner.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kilbouri kilbouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a good idea to adjust the instructions slightly to make them apply to a single workspace, rather than the entire User profile. The reasoning is that EasyMASM only exists in a single folder.

This can be achieved my simply adding a step to switch from the User tab to the Workspace tab in the extension settings.

@jere-mie
Copy link
Owner

It may be a good idea to adjust the instructions slightly to make them apply to a single workspace, rather than the entire User profile. The reasoning is that EasyMASM only exists in a single folder.

This can be achieved my simply adding a step to switch from the User tab to the Workspace tab in the extension settings.

I don't use code runner or do much vscode customization stuff so I don't know much about this... but yea I think making it workspace specific would probably be better than user specific. I wonder if there's a way to automatically handle this by adding a .vscode/ folder to this repo? maybe idk

@kilbouri
Copy link
Contributor

It may be a good idea to adjust the instructions slightly to make them apply to a single workspace, rather than the entire User profile. The reasoning is that EasyMASM only exists in a single folder.
This can be achieved my simply adding a step to switch from the User tab to the Workspace tab in the extension settings.

I don't use code runner or do much vscode customization stuff so I don't know much about this... but yea I think making it workspace specific would probably be better than user specific. I wonder if there's a way to automatically handle this by adding a .vscode/ folder to this repo? maybe idk

Unfortunately, .vscode/settings.json does not currently support platform-scoped settings. This may be a blocker for doing it this way, sadly. Now, on Windows, ./run (in Powershell) does automatically use the .bat file by default.

One solution would be to build a small program to detect the user's platform and run the right script?

@thehamzaihsan
Copy link
Author

Hi there, thanks for you response, added the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants