Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Change approach so ET is calculated in real-time for each sensor group and applied to zones daily or whenever #370

Open
jata1 opened this issue May 18, 2024 · 9 comments
Assignees
Labels
continuous_updates do-not-auto-close Label to make sure it's not auto closed by stale bot enhancement New feature or request

Comments

@jata1
Copy link

jata1 commented May 18, 2024

Is your feature request related to a problem? Please describe.
Currently sensor group data is collected and ET calculated daily then applied to any zone that uses the sensor group. This is not ideal because:

  • you cannot see what the ET for the day so far is based on the sensor data collected
  • there is no way to configure the frequency of data collected for the sensor group
  • ET data has to be applied to all zones at the same time
  • ET is only calculated when it is applied to a zone

Describe the solution you'd like
I would like to see ET data for each sensor group held in separate sensor(s) with the ETO being recalculated each time sensor data is collected. This will allow you to:

  • track ET over time for each sensor group
  • create different ET models and compare them
  • apply the ET to a zone individually rather than all at once
  • more clearly separate sensor group data (ET calcs) from how/when the data is applied to zones.

Describe alternatives you've considered
You can create duplicate sensor groups - e.g. create a group for each zone but it is a work-around and is still limited in that ET is only calculated at the point at which it is applied.

Additional context
I know this is a big change to the overall design of this great integration but I think it is worth considering

@jata1 jata1 added the enhancement New feature or request label May 18, 2024
@jata1 jata1 changed the title [REQ] Change approach so eto is calculated in real time on a sensor group and applied to zones daily or whenever [REQ] Change approach so ET is calculated in real-time for each sensor group and applied to zones daily or whenever May 18, 2024
@jeroenterheerdt
Copy link
Owner

Almost impossible without a complete rewrite since et is not calculated by sensor groups, but by modules which are confused on zones. I don't have time, bandwidth nor interest in doing this at the moment.

@jeroenterheerdt
Copy link
Owner

What's more, this is what our v1 did and we moved away from it because of it being very undefined what et value you'd want to take. It's simply a resolution problem : do you take the average of hourly et? Or minutely et? Neither are great and very prone to overfitting issues. Aggregation to the day level is the right approach IMO, but you indeed sacrifice the real time insight.

@jata1
Copy link
Author

jata1 commented May 18, 2024

I had a feeling it might be tricky but I thought I'd ask. I have only used v2 so wasn't aware you had tried this approach and moved away from it.

What about just having a 'button' that does the ET calculation for a zone based on the data but does not apply it?

@jeroenterheerdt
Copy link
Owner

It's an interesting experiment for sure. Right now let's focus on our other experiment for potential bugs before doing any other changes. Also, very busy with another integration as well. So, really, bug fixes is all I can do here for a while.

@jeroenterheerdt jeroenterheerdt added the do-not-auto-close Label to make sure it's not auto closed by stale bot label May 18, 2024
@jata1
Copy link
Author

jata1 commented May 18, 2024

all good. Thanks for the help. Sorry for all the questions!

what is your 'other integration'?

@jeroenterheerdt
Copy link
Owner

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

@Kurisutian
Copy link

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

Regarding that grill thermometer app, which hardware will this be working with? Any chance it will be compatible with something like https://wlanthermo.de/ ? Sorry to highjack the actual issue a little bit with this question. 😉

@jeroenterheerdt
Copy link
Owner

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

Regarding that grill thermometer app, which hardware will this be working with? Any chance it will be compatible with something like https://wlanthermo.de/ ? Sorry to highjack the actual issue a little bit with this question. 😉

Its hardware independent. As long as it's integrated with home assistant the answer is yes. Feel free to install it and try it: https://github.com/jeroenterheerdt/grillbuddy

@jeroenterheerdt
Copy link
Owner

@jata1 look at this -- a significant step towards direct continous updates of sensors and zones: https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v2024.6.7. please install and try. be careful: there will be bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous_updates do-not-auto-close Label to make sure it's not auto closed by stale bot enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants