Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huge repository #433

Closed
DanielRuf opened this issue Nov 5, 2018 · 12 comments
Closed

huge repository #433

DanielRuf opened this issue Nov 5, 2018 · 12 comments

Comments

@DanielRuf
Copy link

Currently the repo is 328 MB big as there seem to be many big binary files tracked in history and others.

https://github.com/jeromeetienne/AR.js/tree/master/data/videos for example.

@nicolocarpignoli
Copy link
Collaborator

Yeah it's pretty ugly. Can you make a PR for this?

@DanielRuf
Copy link
Author

I'll do a check with BFG.

@DanielRuf
Copy link
Author

Well, but keep in mind that what once was tracked is always left in the history.

@DanielRuf
Copy link
Author

bfg --strip-blobs-bigger-than 1M AR.js.git    

Using repo : /Users/druf/projects/AR.js.git

Scanning packfile for large blobs: 10124
Scanning packfile for large blobs completed in 322 ms.
Found 181 blob ids for large blobs - biggest=90327299 smallest=1049737
Total size (unpacked)=498175801
Found 490 objects to protect
Found 1 tag-pointing refs : refs/tags/v0.9.0
Found 132 commit-pointing refs : HEAD, refs/heads/ZoltanVeres-badges, refs/heads/arcore, ...

Protected commits
-----------------

These are your protected commits, and so their contents will NOT be altered:

 * commit b0fec0c2 (protected by 'HEAD') - contains 49 dirty files : 
	- aframe/build/aframe-ar.js (1,1 MB)
	- aframe/demos/demo-aframe-logo/models/ply/aframe.ply (6,3 MB)
	- ...

WARNING: The dirty content above may be removed from other commits, but as
the *protected* commits still use it, it will STILL exist in your repository.

Details of protected dirty content have been recorded here :

/Users/druf/projects/AR.js.git.bfg-report/2018-11-06/11-51-00/protected-dirt/

If you *really* want this content gone, make a manual commit that removes it,
and then run the BFG on a fresh copy of your repo.
       

Cleaning
--------

Found 1131 commits
Cleaning commits:       100% (1131/1131)
Cleaning commits completed in 1.661 ms.

Updating 132 Refs
-----------------

	Ref                                 Before     After   
	-------------------------------------------------------
	refs/heads/ZoltanVeres-badges     | 8258bdaa | 9ccd641c
	refs/heads/arcore                 | 1c3900fc | 4c0be4cc
	refs/heads/babylonjs-cleanup      | 796199cf | 7b6b6114
	refs/heads/dev                    | bd810c75 | 99bc2f26
	refs/heads/fix-augmented-websites | 0dd39245 | 3c64af61
	refs/heads/gps-ar                 | 126800dd | 1f3145f8
	refs/heads/litegl                 | 9a8416d0 | a378afc4
	refs/heads/master                 | b0fec0c2 | 566f912c
	refs/heads/new-startup            | 22bab7c5 | 201e3e81
	refs/heads/setPattRatio           | 2f42c6b2 | 659cd028
	refs/pull/10/head                 | 7d601f88 | 4ce144bd
	refs/pull/105/head                | 48de4436 | bb7f988f
	refs/pull/105/merge               | 4dbba8df | d0af18d9
	refs/pull/116/head                | d374b6c4 | ec160565
	refs/pull/119/head                | 9fbaa4a4 | 03118e5e
	...

Updating references:    100% (132/132)
...Ref update completed in 130 ms.

Commit Tree-Dirt History
------------------------

	Earliest                                              Latest
	|                                                          |
	DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD

	D = dirty commits (file tree fixed)
	m = modified commits (commit message or parents changed)
	. = clean commits (no changes to file tree)

	                        Before     After   
	-------------------------------------------
	First modified commit | 42a2c6a1 | fd76c44e
	Last dirty commit     | 0fc02f84 | 96d8ece9

Deleted files
-------------

	Filename                                    Git id                                                 
	---------------------------------------------------------------------------------------------------
	20170829-arcore-spawnAtCamera-1.gif       | af0febbd (2,3 MB)                                      
	20170829-arcore-spawnAtSurface-1.gif      | 31391ed3 (1,8 MB)                                      
	20170829-arkit-spawnAtCamera-1.gif        | 3c21daa5 (1,4 MB)                                      
	20170829-arkit-spawnAtSurface-1.gif       | 9aece106 (2,0 MB)                                      
	32211336474_380b67d014_k.jpg              | 8fd2f922 (1,1 MB)                                      
	360_topaz.png                             | 8df596bd (2,1 MB)                                      
	AndraConnect business card.mp4            | 8494b721 (9,0 MB)                                      
	ArcticFox_Diffuse.png                     | 4075e29e (1,9 MB)                                      
	ERROR_chrome_2017-08-18T16-49-55.157Z.png | 64bc0459 (1,3 MB)                                      
	HTC_Vive_controller.obj                   | 4b4c2548 (2,9 MB)                                      
	Regressor.js                              | a578c8ad (4,0 MB)                                      
	Star wars demo Alex.mp4                   | 353d0557 (5,3 MB), a65e098a (37,3 MB)                  
	VID_20160503_165602.mp4                   | a0737ba2 (86,1 MB)                                     
	aframe-ar.js                              | 57c04bcc (1,1 MB), a4f2241b (1,1 MB), ...              
	aframe-city-360.mp4                       | 71d8aa3c (4,3 MB)                                      
	...


In total, 4397 object ids were changed. Full details are logged here:

	/Users/druf/projects/AR.js.git.bfg-report/2018-11-06/11-51-00

BFG run is complete! When ready, run: git reflog expire --expire=now --all && git gc --prune=now --aggressive

Deleted files:

af0febbd8326411b819218ac4399364392d55276 2451120 20170829-arcore-spawnAtCamera-1.gif
31391ed3ab19757d620f71481bf8562753e4a0e1 1935802 20170829-arcore-spawnAtSurface-1.gif
3c21daa56fe11288bf375586f279242346360de7 1451993 20170829-arkit-spawnAtCamera-1.gif
9aece10608c15586a2c74047c7102e984673f5f4 2110641 20170829-arkit-spawnAtSurface-1.gif
8fd2f922807515650d273cd89110e70880712a6d 1106916 32211336474_380b67d014_k.jpg
8df596bd5c4c1203f5ded2922ee7f5fa74f85722 2188909 360_topaz.png
8494b72123858786d46e1b2ae7900d507118fbfd 9485667 AndraConnect business card.mp4
4075e29ed94f0cbc95a2d256d6077cf320adcb6e 1990735 ArcticFox_Diffuse.png
64bc04594db3415ad41ecf843b584a10bc8fbf06 1365846 ERROR_chrome_2017-08-18T16-49-55.157Z.png
4b4c25487dde8a9ce3232f5426fb519ac5c0c3b8 2999181 HTC_Vive_controller.obj
a578c8ad526fc243d7852dda89243018ffcf7234 4200009 Regressor.js
353d055760f83121de736cb97009d48db62e9d4b 5587946 Star wars demo Alex.mp4
a65e098af5c2ef3f531390b8f8798faad33b611f 39088976 Star wars demo Alex.mp4
a0737ba2c8d0ffb1fff47450956431cfa2950579 90327299 VID_20160503_165602.mp4
670764a304f20d578af0eb4b0936b1f34bba680e 1106288 aframe-ar.js
6b5764268d800f7cc28d2354f889f96c1b256f4e 1111985 aframe-ar.js
57c04bcc01dbc0c7540ba5e791bfdc2615e0551a 1106831 aframe-ar.js
5ba0abc59724862f3defb88e3ac3a4df5bf327e5 1111991 aframe-ar.js
a3817ebb70bf98642adeaa70757d6fcde2360370 1097636 aframe-ar.js
3ab0c9ce0aa1f914c48c037d939660cd0cc5172b 1112281 aframe-ar.js
f30935ab8fb16ea59bcf34732e5eb8af2e54b2a4 1112088 aframe-ar.js
f52b3375641fad45b6a8ee7fc5c55579c0ea5cd1 1085395 aframe-ar.js
ba38bd52fe436a0b58ee47679ca6b3df9ea4e0d7 1112227 aframe-ar.js
416189dbff7ce49ff309e3389bc6e25c54ca6ef9 1112121 aframe-ar.js
043ae13b7c8314c91095a1a7b8ac2873bbd70c91 1097304 aframe-ar.js
f6a59650e03b112fb69b6c5400d2b844d29771fe 1091419 aframe-ar.js
d78eb5a8b2ec6f2daf2c4528ca8e4acbd1a8c438 1100715 aframe-ar.js
5948ce2d5fa9f5cd83851888c8cf740bc47f8701 1115228 aframe-ar.js
1534176c08c85068c9bc83686ae78107cf1193af 1112614 aframe-ar.js
dd01b9c5fa008f034e5186cf79943009b6536121 1083645 aframe-ar.js
a704ca7d7f50c5a8c15476b03cc0fc26ecd81356 1106831 aframe-ar.js
e650513589cd7b6bf0a47a03497f49c641fd152e 1097636 aframe-ar.js
e331796cff4e4b45ed86bfa570731c4bdc355814 1100536 aframe-ar.js
f6d3ccc4a39b9d8ca5077dac90669a2683054f02 1097636 aframe-ar.js
fd6556fda163a7a639f5a307debe61d26afbe23b 1097637 aframe-ar.js
1378eebc7ac642da60bd1e5e3e77d5ee01f3d943 1112088 aframe-ar.js
804597f6efb3c889b5f0d75e99fe4ac867b44dfb 1100504 aframe-ar.js
574eeea6415bdbfc1e9d1f413f681dec6d17037e 1101222 aframe-ar.js
95073d5304d170b70fe99e3afb6fabdf172a4a49 1101496 aframe-ar.js
1b798adf7eed0990f552cff6f7f2aa65005053a2 1097374 aframe-ar.js
64b0439dc27900a7ea98b8030f8fe04bf9997ad5 1110089 aframe-ar.js
300034be9c6b5dd0683cccd183bc4babdc212bd6 1112973 aframe-ar.js
cc4721bc7f4808cd69a12fa44743ee7636eb4d19 1106537 aframe-ar.js
46d0ecee14576851eed53e054294ec7c817c3202 1112281 aframe-ar.js
0c8bafbb0370c70a11e27aac75db8d023fe27463 1112351 aframe-ar.js
3b374c43fcbb42e6210bdc7998316e05e5730c5d 1097298 aframe-ar.js
11a5b014bf493c2906d75c5d6ecedcf8272b3aed 1101496 aframe-ar.js
6ae3154830f17b66ff06a09927588d5e7f6baa1b 1112973 aframe-ar.js
ce9ed6d55e8a79c3a1efd98751418891574897b7 1112988 aframe-ar.js
abe993fc4ee55521a5eeb57b862f184a71673c52 1112973 aframe-ar.js
12769d4fd30d15dc2acf0aa7e84e5beb21576155 1097640 aframe-ar.js
a4f2241b31c04b6d633ecf16e3c51f6fd8e45d9c 1111795 aframe-ar.js
6bf4871ca2a7818a82a4ca1046c37a8d31485182 1101232 aframe-ar.js
71d8aa3c5e4e09c5af4b7adf2ca8d98e4f11a55d 4547079 aframe-city-360.mp4
4b07e7d959031c1966a6fff4e82792c2f85728ee 2118426 aframe-v0.6.0.js
ebaf8ebd9f443958074d7535de555813a7196644 1083236 aframe-v0.6.0.min.js
b26bb176c6e04ed88341e1f9ae3b06b2a3213d3f 2135715 aframe-v0.6.1-three-r86.js
9827e6ab859e65536aa3d63a9dd49f1d94f923c6 1437488 aframe-v0.6.1-three-r86.min.js
4b07e7d959031c1966a6fff4e82792c2f85728ee 2118426 aframe.js
a975b6376a7e94b9bc7f3b785e1ec7adaae8bd1e 1815645 aframe.js
b26bb176c6e04ed88341e1f9ae3b06b2a3213d3f 2135715 aframe.js
d49767e1a2aaca8826a6824b82a7405e0670b775 2067341 aframe.js
ebaf8ebd9f443958074d7535de555813a7196644 1083236 aframe.min.js
6cba1fc9e99ebab38e3f9b3f74bb687f6094a55a 1049737 aframe.min.js
9827e6ab859e65536aa3d63a9dd49f1d94f923c6 1437488 aframe.min.js
dd82b0e407916daa262e7f55d15fcbc72f555464 6571953 aframe.ply
3a928835388adf7aed85a20c67c15d974e984b84 1474290 ammo.js
50c8c88c760f0fc83b68b07cbb1687d80f8cbce9 1081624 ar.js
a783968ac3fde241e1a9df4d9e1a33968c7f02f4 1093619 ar.js
5b86b706c1b47d65e3e645d8e4dc9a56c7456c63 1079493 ar.js
3f5db195df6b287e7e0a998f8160bdb698047646 1092982 ar.js
9c193d6c7feb73ab42f9c0b34e6b3832d176b649 1079493 ar.js
7c7d8d613d6509e356d4316ada2da499b5ce8ecd 1087752 ar.js
c8a7cf5a93b8a088d9edb425eb7440f1168577ca 1078818 ar.js
31d60ca7dabb700d21f910b95a4f671b6d2e4f38 1093099 ar.js
0a46975d7502fd18a0d9601cb048f91249b279df 1071044 ar.js
9e336c0ec4bd25adeb3f311351a3a0585fdd36ac 1079164 ar.js
52c7e9d5f84bb84b04b89d021fdf272fb964157b 1092725 ar.js
2edfff98badf82c2d540d54cddad45caf1525218 1079494 ar.js
67c57845611b65395a0a4a1d4f9143e4cb4309dc 1093099 ar.js
e366f8517bf11825c31f8250866c4119f15b1fe1 1091170 ar.js
d96d3fb414d78c83ea7d966620403d34220077ad 1081628 ar.js
8dda28190f407df17fe5e4b1c3664aae8ca53678 1087912 ar.js
a8fd2a3bcb4cdc9e16861f1ed27842a4384538a2 1082577 ar.js
7f3348e89835c1827cca455e44cfc40531756ec7 1092129 ar.js
106a088b04ffc28daa14be3a2986200ef168cb42 1079166 ar.js
c1a9fc8f65627284c9235c1a852205df3f692bc4 1082577 ar.js
ab2ec20154dcc3de17048690f71b380c9a2ee8a2 1074764 ar.js
d8bd047d4816680b44396183c600da0d6d9e8e4e 1092912 ar.js
0bfbe1730f8d154f64c8202f6d20907b4777264d 1082303 ar.js
499ef31cca99e61ac6e3106e1b5a09507ad79da7 1093099 ar.js
6df865a754891ef54adcbe63a095c0330690cb20 1054466 ar.js
eb1072aa54ae612bb18f988168e173635494ae94 1082313 ar.js
43257e9632170bcc43cc0654887da5e06ca3abff 1092912 ar.js
f2b24112c84a6e4be567f273da09c1e23c5588e4 1087912 ar.js
33e24a6326f2300361430b68e6fadcdf8d68c8aa 1092725 ar.js
e3075a36fd47c521287e807d048f2ad818c16f64 1072794 ar.js
7a22c1de9e6e6fb8d78686dde4a210d1d0aeb961 1092855 ar.js
ed93783367f55020b8faf62714bfe5b21ee3d96f 1092822 ar.js
7a9e6a73bac1bf5e7aacb968375f8c15a6ac08a7 1081613 ar.js
c636905c730ec5bc85b7a4f79868801027d07ee1 1096297 ar.js
47e08bf84a25ec82cc577bfc877aa5702593b020 1054461 ar.js
789bec13eedb3803e6c2f4219d17bba2500074e8 1079497 ar.js
5e6e5cdd94cb06ed9f71858dd7338314aea959ac 1081413 ar.js
4e36e3396237c36b4190667386c5568b7efeaf73 1082578 ar.js
bc56f1d76431d4aad22d094b9862c1e991c2d4c5 1087618 ar.js
e7625a25dc7920aed156e149585ce08be1999d90 1092822 ar.js
7b485944780bb70aa9a7be2e50a0417b478cfa82 1098477 artoolkit-webvr-polyfill.js
a782d91617a6bc5cb15c512d53f5100ac8ac7bf2 1103290 artoolkit-webvr-polyfill.js
2e66777f8064f652a6b7e3573ed93267f7878758 1090059 artoolkit-webvr-polyfill.js
9006d9b85ed6b0f2852525c0c1243919c5afc0f6 1092868 artoolkit-webvr-polyfill.js
5f73648f64c7f29d7cf360ac95c84ad07223fa6a 1091978 artoolkit-webvr-polyfill.js
24c6e433f259b020d4996e38ed4555317e3d9688 1093142 artoolkit-webvr-polyfill.js
8b58b07117aa3354012ccb52de6bb6f05fd16391 1098477 artoolkit-webvr-polyfill.js
f6f1d6ee291a62dec4daf634afc0734cf69fe167 1103290 artoolkit-webvr-polyfill.js
78a47381d3ecd44a070fa9adb6f36ed34fa43b6d 1090062 artoolkit-webvr-polyfill.js
d3931d8fa41aad40f7ab5c9c7a1e4a61e6a360fe 1093142 artoolkit-webvr-polyfill.js
466a3bb73ae6cf7720eb106842604abe15ac02ab 1090058 artoolkit-webvr-polyfill.js
65339d5947c4f86c5c6c912314439dda0e473c34 1098183 artoolkit-webvr-polyfill.js
bdd98d174bd5d14647b6cedb3b1eca461deb1319 1089731 artoolkit-webvr-polyfill.js
e2605fc2ec8945fe7c742b8985abcf04d72ce856 1089729 artoolkit-webvr-polyfill.js
7990f945b10ab3cde7e0f55bed12875b88622569 1090058 artoolkit-webvr-polyfill.js
3f0b7a195c0dbcd3c3419e07a80bb1918bb6760d 1101735 artoolkit-webvr-polyfill.js
5c5756f266ad25deb6b0d5d5cf9eb78d94719f0e 1089383 artoolkit-webvr-polyfill.js
9d0aad4b038914f19e57071f589ebec1e5f12bc7 5154209 artoolkit.debug.js
5b94e83968fcdc14bb7b6375525fcda8b4997bce 2950253 artoolkit.debug.js
6a59462a621f57ab0f5fdffe79fef44220a6d646 1528613 artoolkit.min.js
f2b71bed5d0bf0d1b42918c48fd42d0147fe69ea 2130749 babylon-ar.js
56c85da024a1d9de57e47142984c46824e46add4 2136083 babylon-ar.js
f1f19d568a760893084e75679efe61f82d789a11 2130748 babylon-ar.js
96307b5c69c9bb787ddac676ad460e78ed5cca73 2139516 babylon-ar.js
5e511128787790727182c1c87d32bdfec1e93f85 2127723 babylon-ar.js
887959fa50291fd312c7d0188d485b64895e63d5 2134204 babylon-ar.js
1dbef2e12c74d944ad9ee549b2822c423998a424 2141071 babylon-ar.js
6ead48669ed8722b449d7c5e0447ba591621f1a3 2130748 babylon-ar.js
ae05f7a174d155ac50fa61e3ec47930c00f22318 2141071 babylon-ar.js
655f670dca935d19faa2ea51acad87958782251f 2135789 babylon-ar.js
48ec25c5fb4efdf7f662333cff7123edcaf63b0d 2136083 babylon-ar.js
0dc17fb63e1596956fb5988409b35e16226a1cdc 1681109 babylon-ar.min.js
da3caa259910b2a4cfa0c48c83e9e041b8126b9c 1671517 babylon-ar.min.js
d89858151aa1da073fff9c578a6b75f6af59f403 1671517 babylon-ar.min.js
3d9bb006a1a6ab792554b681100cd3e9b9056fe5 3161109 babylon.max.js
2cb6b8152b5d9034ed9cf5a298ca32d14bdce0a3 12889828 chromedriver
a5ba4acb8eecbc8a0ff01cba98b776208ddd43ce 11688344 chromedriver
c4bca5fe294509a584c89282d6fd95ac2eb15a6b 7411391 closure-compiler.jar
67c9c613473044683029987f8e7322ce0955f76a 3387403 franck.mp4
a4f6e37f6b937ecd1718d9817094c63fbee5a3c2 8138867 franck.ogv
c7b04fa7a3c7bd56c6dbbed5a78ba00de6ae432b 7062996 geckodriver
e51f387d0ab0c10b2c7a4433f442ffd629d00bff 3330688 geckodriver
5a412d4ef9212d419057c370e14d1e823337eddb 7599278 headtracking.mp4
750025e40cbe8593c52664a3253106ce630e4a1a 1239074 litescene.js
56bf52860fa8fe5b44e913a15498e0a06fa3b4a5 1896408 logo-black-transparent-20480x8192.png
09963e418b5c65a00c53596504797e398f89aee2 1769683 logo-white-transparent8-20480x8912.png
d36d10c813902aba19316cb08bebed5a22937a22 3847800 magic-book.jpg
506c88c3c91e1c58390f5bf612e3d96449249567 12126483 magic-book.mov
aee27ade9634b4cc4a2097ee85b4b46cfd95ec92 3214649 magic-book.mp4
2b4258debcb1ed46268f6a77fee4e2b5fdbfd486 2502289 magic-book2.png
d36d10c813902aba19316cb08bebed5a22937a22 3847800 magical-book.jpg
0b71de3084403ff85d19c8de74bc3baa5e898940 4000779 markers-page-ipad.jpg
03566118d5a5ecbdcbb4443b56ddfa6b5bef2f6d 31194752 markers-page-ipad.mp4
7c8347877ce27b981103a390e2aef299ff18db06 2421608 multimarker.jpg
a8e58eefd0c665a23bceee0cc1a6fefe547356d8 2122149 output_4.mp4
244f972314d9ba4d1d887d0f949bacf586ef0fe0 1074977 pdfmake.min.js
887959fa50291fd312c7d0188d485b64895e63d5 2134204 portable-ar.js
bd86fff9c2f872b947d8250ffbd67806fa625560 2139215 portable-ar.js
597e538ddcd2983f9a299da256416298a03600d3 2141156 portable-ar.js
36e52ba6444bc62ddb00e5e4f57adc48f17d7851 2139402 portable-ar.js
b9c253917c3715890c9be7c845fb81ce66edc21a 2139402 portable-ar.js
98513a6f56c5c6c8f79b5f6342edb9cbafd47180 2139215 portable-ar.js
0f8676e5d34328a396f982d0e9f8b530b06832d0 2139158 portable-ar.js
6142a9d3f725e02b9fd9277226e6937cfb27d3dc 2139402 portable-ar.js
4f5227996a31e5b450e2d000758b1cf193fdb6db 2139016 portable-ar.js
03a4f08def6467ef4bd811d61fb4477811d3d134 2140339 portable-ar.js
5e81113423d538a885f052b73ec0b5288564ee9e 2139125 portable-ar.js
87da947e6e0d4f544619e63645cdec1c1e5ba7d0 2139125 portable-ar.js
466c03a5d2bac2993cf622c9260cff16d27951a6 2139285 portable-ar.js
59984f0ee159e425283ec93e0d74c179051f692a 1679576 portable-ar.min.js
8bf948c2712766eb6f0f037fef3efed150e40b3b 1677139 portable-ar.min.js
b1e9cbcea1fafef24aaee57368eb4d8e4d3d866b 1677334 portable-ar.min.js
400dc9982c5b0fc8f988e8179227aa0addbb6024 1673587 portable-ar.min.js
112c395546a5b1e2490244bcb5aa1ac51b3701a1 1677334 portable-ar.min.js
d0c674446d33e9bff224150d3635a1583d832c13 6139475 seating.ply
d9fd93e361e5e7e52e7dc404bf1a3f9d7e48233a 22139212 selenium-server-standalone-3.0.1.jar
a9cdd36176bcfc5697e12394c12e52e621693cd0 3243166 sintel.webm
cfa19e1529110cb086d953c80d834243adddda59 1572986 skybox_rgb.dds
dc0756a8b0ed2c000717cea2dac9d56bf773c4c3 3818057 stadium.ply
268cec88cf7a91ba1cc172e85455c6b613d9e9c0 1601247 wavefile_v2.vmd

@andreyrd
Copy link
Contributor

You'll probably want to run it with a file size bigger than 1M, considering the library output itself is 1.06mb, but that also could be an argument for not including build files in git.

@DanielRuf
Copy link
Author

not including build files in git

Extly. Also the content / files can differ from the files which are uploaded to npmjs and so on for example.

We can attach / upload dist files to releases on GitHub and builds should be reproducible in general.

@trusktr
Copy link

trusktr commented Nov 26, 2018

not including build files in git

I think it is good to include, f.e. so people can easily grab the global version and stick it in a script tag. It's developer ergonomics (especially for new devs, or people who just want to quickly make a codepen, etc, using rawgit for example, or maybe they just want to quickly download the built file by hitting the "raw" link, etc). So 1mb for the build output is nothing.

But definitely would be nice not to include videos, and other huge files. 👍

@DanielRuf
Copy link
Author

I think it is good to include, f.e. so people can easily grab the global version and stick it in a script tag

You can use unpkg for this and upload the dist files only on npmjs and ignore them in the repo.

@DanielRuf
Copy link
Author

PS: https://rawgit.com was shut down.

@trusktr
Copy link

trusktr commented Nov 29, 2018

You can use unpkg for this and upload the dist files only on npmjs and ignore them in the repo.

True, but some people don't know about it and they'll see the repo and be able to easily grab it. But I suppose we can document unpkg in the README.

If unpkg ever shuts down, at least the one in the repo would be there.

That's too bad about rawgit!

@nicolocarpignoli
Copy link
Collaborator

nicolocarpignoli commented Dec 23, 2019

nicolo:AR.js nicolo$ du -hs ./*
 28K	./AR.js-1920-1080-HD.png
 12K	./CHANGELOG.md
4.0K	./CODE_OF_CONDUCT.md
4.0K	./CONTRIBUTING.md
4.0K	./HOW_TO_RELEASE.md
4.0K	./ISSUE_TEMPLATE.md
4.0K	./LICENSE.txt
4.0K	./Makefile
4.0K	./PULL_REQUEST_TEMPLATE.md
 20K	./README.md
 24K	./TODO.md
 36M	./aframe
 21M	./data
 84K	./node_modules
4.0K	./package-lock.json
4.0K	./package.json
 86M	./test
 53M	./three.js

will do something about it on a next release

@nicolocarpignoli
Copy link
Collaborator

closed, see related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants