Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 Release: NFT + code cleaning + doc update and other improvements. #722

Closed
wants to merge 98 commits into from

Conversation

kalwalt
Copy link
Contributor

@kalwalt kalwalt commented Feb 4, 2020

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️
From #674 (comment) #674 and #705
What kind of change does this PR introduce?
This PR want to test the new jsartoolkit5 from kalwalt/jsartoolkit5#1 with the new changes especially the NFT part.

🖼 This will eventually make AR.js capable of detect and track 2D images.

https://twitter.com/nicolocarp/status/1204841439160684549

Could be raise some bugs and incompatibilties between the code. It is more a test...
Can it be referenced to an Issue? If so what is the issue # ?

From jsartoolkit5 repo: PR kalwalt/jsartoolkit5#1
From AR.js issues:

also, a repo cleaning will help for: #433

How can we test it?
Just test the examples and tell us what happens...

Summary

Does this PR introduce a breaking change?
Nope, it will remove old code, but unnecessary. It will add NFT feature.

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Other information
I uploaded the new jsartookit5 libs and build the AR.js libs with makefile.

Progress

  • Clean repo before starting the porting
  • Import new jsartoolkit5 version, coming with NFT
  • Adapt the code (threejs side) to support NFT (emulate what's already done for fiducial markers)
  • Fix the rendering of content on AR.js side, for NFT (onMarkerFound function)
  • Make it work on mobile
  • Enhance resolution in both mobile and desktop
  • Check if animations work with NFT. If not, or rendering rate is too high, use interpolation
  • Fix broken pattern marker (content appears shifted after NFT modifies, or maybe even before during the cleaning of the repo)
  • Remove all rendering code on the Worker
  • Adapt the code (aframe side) to support NFT (emulate what's already done for fiducial markers)
  • Create at least one example for threejs + NFT
  • Create at least one example for aframe + NFT
  • Change documentation (principal Readme, also with NFT Marker generator + Readmes inside threejs + aframe folders)
  • release version 3 of AR.js

kalwalt and others added 30 commits December 12, 2019 19:10
…jsartoolkit5-NFT

# Conflicts:
#	three.js/examples/test-runner.html
…jsartoolkit5-NFT

# Conflicts:
#	three.js/experiments/deadreckoning.html
@nicolocarpignoli
Copy link
Collaborator

We are almost there! I think that two enhancements can be added in the future, not in v3 release:

  • cable positioning of content of NFT inside the core
  • cable smoothing on NFT inside the core.

Actually it works defining it on three.js or aframe side.
But it's not that bad, user can have more control this way.
Eventually, we will add defaults in the future.

@nicolocarpignoli
Copy link
Collaborator

Issue to be added for NFT AFTER release:

  • cable positioning of NFT content (to center it) inside the core
  • cable smoothing on NFT inside the core
  • make NFT work on Desktop too.

@Marcus5234
Copy link

Wow v3 seems really close to being released. A week is a good estimate? Can't wait for this! Mate, this will cover like 90% of all AR use cases! I can say goodbye to zappar, 8thwall, awe, vuforia, easyar, arcore, arkit. Well, except when I need world tracking, facetracking. superimposition...but those are the 10% arjs won't cover.

@nicolocarpignoli
Copy link
Collaborator

Wow v3 seems really close to being released. A week is a good estimate? Can't wait for this! Mate, this will cover like 90% of all AR use cases! I can say goodbye to zappar, 8thwall, awe, vuforia, easyar, arcore, arkit. Well, except when I need world tracking, facetracking. superimposition...but those are the 10% arjs won't cover.

Could be a good estimate :)
We hope to release an useful feature. And hope to get more contributions to make tracking even better. We will see 💪🏻

@kalwalt
Copy link
Contributor Author

kalwalt commented Feb 28, 2020

Wow v3 seems really close to being released. A week is a good estimate? Can't wait for this! Mate, this will cover like 90% of all AR use cases! I can say goodbye to zappar, 8thwall, awe, vuforia, easyar, arcore, arkit. Well, except when I need world tracking, facetracking. superimposition...but those are the 10% arjs won't cover.

Yeah it seems that we are on the way! Maybe not a week but we are very optimistic. I'm also very happy, for all the effort that me and @nicolocarpignoli have spent on this, and i hope you all will make awesome project with it!!

@kalwalt
Copy link
Contributor Author

kalwalt commented Feb 28, 2020

@Marcus5234 and all following this PR, check also this other PR #742 probably this will be the final and definitive Pr with the working code.

@nicolocarpignoli
Copy link
Collaborator

closing, please refer to: #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants