1st cleanup pass for Anaconda easyblock

[boegel]

for easybuilders#950

@jerowe I cleaned things up a bit, major changes are:

• derive from generic Binary easyblock to avoid code duplication
• use adjust_permissions function rather than chmod
• add custom sanity check in easyblock (rather than copy-pasting it in easyconfigs)
• minor code style fixes

This is just a 1st pass, I expect to do additional passes, mostly in relation with the CondaCreate and CondaEnv easyblock that leverage parts of the Anaconda easyblock.

Please take a look at the proposed changes, let me know if you have any concerns.

If you merge this, easybuilders#950 will be updated as well.

[jerowe]

Will this remove the extract_step for all the blocks? In CondaEnv I am sometimes pulling from a remote environment, which means there is no file source. Will this have an effect if there is no source?

[boegel]

This only makes the change in the Anaconda easyblock, I haven't looked at the Conda* yet.

I think there may be some cleanup possible there too, I'll look into that later.

[jerowe]

Fair enough. ;-)

This is the master branch , and I had most of my changes in the develop branch. I am sharing some functions between the three EBs, but I don't remember exactly which functions.

[boegel]

What do you mean by 'this is the master branch'?

I've targeted your develop branch using this PR, which is also the one you used for easybuilders#950

[jerowe]

You're right. I don't know why I thought it was the master branch. My kids are bouncing around, and I should have sat down and been more careful about collecting my thoughts. ;-)

[boegel]

Hah, I know the feeling! :)

[jerowe]

@boegel , have you had a chance to take a look at the conda blocks?

[jerowe]

Thanks, @boegel . I had one comment about removing the extract step, but besides that it looks great. ;-)

[boegel]

@jerowe thanks for the merge, pleas take a look at jerowe/easybuild-easyconfigs#1 too