Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding downloading_time parameter #88

Merged
merged 5 commits into from
Apr 30, 2022

Conversation

dantebarba
Copy link

Hello,

One of the issues that I came across when using autoremove-torrents, is that there is no way to measure the elapsed downloading time. This has been somewhat discussed in issue #87. Fortunately there is a solution for transmission at the moment. I don't know if this can be implemented with other download clients. They all have the "seeding_time" parameter, so they should have the downloading_time parameter too am I right?.

Why do we need downloading_time?. Well in my particular case I use autoremove-torrents to deleted stalled or slow torrents. Without the possibility of accurately measure time (last_activity starts in a very low value and create_time starts measuring when the torrent is added not when the torrent is downloading, so it's useless too), it's impossible to filter these torrents. With downloading_time I could specify a condition that is "downloading_time greater than 900 secs and average_downloadspeed lower than 512 kb/s" and all torrents that are slow or not downloading at all for more than 15 minutes would be removed.

Dante Barba added 4 commits September 19, 2020 00:12
- It should work with transmission, not tested with other torrent clients
- Unit tests are missing :( please complete for PR.
@jerrymakesjelly
Copy link
Owner

jerrymakesjelly commented Apr 30, 2022

Looks good to me. Thanks for your contribution!

@jerrymakesjelly jerrymakesjelly merged commit 7cafa47 into jerrymakesjelly:dev Apr 30, 2022
@jerrymakesjelly jerrymakesjelly mentioned this pull request Jun 19, 2022
@KyleSanderson
Copy link

Hello,

One of the issues that I came across when using autoremove-torrents, is that there is no way to measure the elapsed downloading time. This has been somewhat discussed in issue #87. Fortunately there is a solution for transmission at the moment. I don't know if this can be implemented with other download clients. They all have the "seeding_time" parameter, so they should have the downloading_time parameter too am I right?.

Why do we need downloading_time?. Well in my particular case I use autoremove-torrents to deleted stalled or slow torrents. Without the possibility of accurately measure time (last_activity starts in a very low value and create_time starts measuring when the torrent is added not when the torrent is downloading, so it's useless too), it's impossible to filter these torrents. With downloading_time I could specify a condition that is "downloading_time greater than 900 secs and average_downloadspeed lower than 512 kb/s" and all torrents that are slow or not downloading at all for more than 15 minutes would be removed.

This is broken in certain circumstances... some objects have it, others don't.

Tue, 07 Feb 2023 02:11:27 autoremovetorrents.strategy INFO: Running strategy stalled...
Tue, 07 Feb 2023 02:11:27 autoremovetorrents.main ERROR: autoremovetorrents.exception.unsupportedproperty.UnsupportedProperty: 'Torrent' object has no attribute 'downloading_time'. Your client may not support this property, so the condition downloading_time does not work.
Tue, 07 Feb 2023 02:11:27 autoremovetorrents.main ERROR: Task bustedshit fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants