[WIP] Adopt flag prep logic #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes an issue for the semantic diagnostic phase. Remove this flag on the server to simplify the client.
In hindsight, it was a shitty decision to put flag prep in the client ( Probably a whisky driven design decision ) Revert this mistake. The CompilationDatabase should be an input to Swift services and tools ( like how this works in clang ). Now the client simply prepares a CompilationDatabase, and sends us commands from that. We need to process flags for diagnostics and it is more reasonable to have all of this flag logic happen in 1 place, and have clear definitions of what the server accepts as input for these flags. resolves #6 There should be a PR to YCMD as well ( or just merge into ycm-core/ycmd#487 ) TODO: Additionally consider making the flags accept a string instead of an array. It is insane to convert the string to an array on the client.
jerrymarino
force-pushed
the
jmarino_move_flag_prep_logic
branch
from
dbb3293
to
eda08c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move flag prep to the server: convert a
commandfrom aCompilationDatabaseto arguments we can use for completions and other tasks.We need to process flags for diagnostics and it is more reasonable to have all of this flag logic happen in 1 place, and have clear definitions of what the server accepts as input for these flags.
Now the client simply loads a
CompilationDatabase, and sends us commands from that. TheCompilationDatabaseshould be an input to Swift services and tools ( like how this works in clang ).TODO:
Additionally consider making the flags accept a string instead of an array. It is insane to convert the string to an array on the client i.e.
shlexon the client!resolves #6
Send a corresponding a PR to YCMD as well ( or just something merge into ycm-core/ycmd#487 )