Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Amazon SNS Alerter #1003

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Fix Amazon SNS Alerter #1003

merged 3 commits into from
Nov 9, 2022

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Nov 9, 2022 •
edited
Loading

Description

aws_secret_access_key=self.sns_aws_access_key_id,
↓
aws_secret_access_key=self.sns_aws_secret_access_key,

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel jertel merged commit 72c6103 into jertel:master Nov 9, 2022
@nsano-rururu nsano-rururu deleted the fix_sns branch November 9, 2022 15:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsano-rururu @jertel