Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local testing instructions to the contributors' guidelines #147

Merged
merged 4 commits into from
May 10, 2021
Merged

Add local testing instructions to the contributors' guidelines #147

merged 4 commits into from
May 10, 2021

Conversation

ferozsalam
Copy link
Collaborator

No description provided.

@nsano-rururu
Copy link
Collaborator

nsano-rururu commented May 10, 2021

I think you should run sudo make clean before running make test-docker. When I added the python library to requirements.txt, it couldn't be installed successfully.

Also, if you look at docker ps -a, after make test-docker is finished, the container will accumulate more and more with the container stopped, so you need to delete it regularly.

@ferozsalam
Copy link
Collaborator Author

@nsano-rururu I have updated the PR to include sudo make clean, thanks.

Regarding the containers that are left behind, I think that can be fixed by changing docker-compose --project-name elastalert run tox to docker-compose --project-name elastalert run --rm tox in the Makefile. I'm just confirming now, but if it all looks OK I'll put in a separate diff for that in a moment.

@jertel jertel merged commit 582396b into jertel:master May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants