Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all the alerter tests into individual files #175

Merged
merged 1 commit into from
May 22, 2021
Merged

Migrate all the alerter tests into individual files #175

merged 1 commit into from
May 22, 2021

Conversation

ferozsalam
Copy link
Collaborator

No description provided.

@nsano-rururu
Copy link
Collaborator

@ferozsalam

Why didn't you move the following files to the alerters folder?

thehive.py
dingtalk.py

@ferozsalam
Copy link
Collaborator Author

@ferozsalam

Why didn't you move the following files to the alerters folder?

thehive.py
dingtalk.py

I didn't see them, thanks for letting me know.

I will move them in a separate PR.

@jertel jertel merged commit 7ba9cc7 into jertel:master May 22, 2021
@nsano-rururu
Copy link
Collaborator

@ferozsalam

Only the file name of zabbix test code ends with _text.py instead of _test.py.

the current

zabbix_text.py

Correct name

zabbix_test.py

@ferozsalam
Copy link
Collaborator Author

@nsano-rururu thanks, will fix.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants