Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics_writeback takes three positional arguments #253

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: metrics_writeback takes three positional arguments #253

merged 1 commit into from
Jun 8, 2021

Conversation

greut
Copy link
Contributor

@greut greut commented Jun 8, 2021

Hey, running on 2.1.0 I'm hitting that when activating the prometheus metrics wrapper.

Cheers,

ERROR:elastalert:Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/elastalert/elastalert.py", line 1506, in alert
    return self.send_alert(matches, rule, alert_time=alert_time, retried=retried)
  File "/usr/local/lib/python3.9/site-packages/elastalert/elastalert.py", line 1615, in send_alert
    res = self.writeback('elastalert', alert_body, rule)
TypeError: metrics_writeback() takes 3 positional arguments but 4 were given

Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jertel jertel merged commit 90c1d2a into jertel:master Jun 8, 2021
@greut greut deleted the fix/metrics_writeback_takes_3_pos branch June 8, 2021 14:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants